Skip to content

Parse raw identifiers (r#<identifier>) in expressions #7137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ where
let type_parameters_constraints =
self.generate_type_parameters_constraints_code(type_parameters, Some("AbiEncode"));

let name = name.as_str();
let name = name.as_raw_ident_str();

if body.is_empty() {
format!("#[allow(dead_code, deprecated)] impl{type_parameters_declaration} AbiEncode for {name}{type_parameters_declaration}{type_parameters_constraints} {{
Expand Down Expand Up @@ -67,7 +67,7 @@ where
let type_parameters_constraints =
self.generate_type_parameters_constraints_code(type_parameters, Some("AbiDecode"));

let name = name.as_str();
let name = name.as_raw_ident_str();

if body == "Self { }" {
format!("#[allow(dead_code, deprecated)] impl{type_parameters_declaration} AbiDecode for {name}{type_parameters_declaration}{type_parameters_constraints} {{
Expand All @@ -92,7 +92,7 @@ where
for f in decl.fields.iter() {
code.push_str(&format!(
"let buffer = self.{field_name}.abi_encode(buffer);\n",
field_name = f.name.as_str(),
field_name = f.name.as_raw_ident_str(),
));
}

Expand All @@ -108,7 +108,7 @@ where
for f in decl.fields.iter() {
code.push_str(&format!(
"{field_name}: buffer.decode::<{field_type_name}>(),",
field_name = f.name.as_str(),
field_name = f.name.as_raw_ident_str(),
field_type_name = Self::generate_type(engines, &f.type_argument)?,
));
}
Expand All @@ -121,10 +121,10 @@ where
engines: &Engines,
decl: &TyEnumDecl,
) -> Option<String> {
let enum_name = decl.call_path.suffix.as_str();
let enum_name = decl.call_path.suffix.as_raw_ident_str();
let arms = decl.variants.iter()
.map(|x| {
let name = x.name.as_str();
let name = x.name.as_raw_ident_str();
Some(match &*engines.te().get(x.type_argument.type_id()) {
// unit
TypeInfo::Tuple(fields) if fields.is_empty() => {
Expand Down Expand Up @@ -156,12 +156,12 @@ where
return "".into();
}

let enum_name = decl.call_path.suffix.as_str();
let enum_name = decl.call_path.suffix.as_raw_ident_str();
let arms = decl
.variants
.iter()
.map(|x| {
let name = x.name.as_str();
let name = x.name.as_raw_ident_str();
if engines.te().get(x.type_argument.type_id()).is_unit() {
format!(
"{enum_name}::{variant_name} => {{
Expand Down Expand Up @@ -320,6 +320,9 @@ where
for r in contract_fns {
let decl = engines.de().get(r);

// For contract methods, even if their names are raw identifiers,
// we use just the name, because the generated methods will be prefixed
// with `__contract_entry_`.
let name = decl.name.as_str();
if !contract_methods.contains_key(name) {
contract_methods.insert(name.to_string(), vec![]);
Expand Down Expand Up @@ -424,7 +427,7 @@ where
});
return Err(err);
};
let method_name = fallback_fn.name.as_str();
let method_name = fallback_fn.name.as_raw_ident_str();
match fallback_fn.purity {
Purity::Pure => {}
Purity::Reads => reads = true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ where
let type_parameters_constraints =
self.generate_type_parameters_constraints_code(type_parameters, Some("Debug"));

let name = name.as_str();
let name = name.as_raw_ident_str();

format!("#[allow(dead_code, deprecated)] impl{type_parameters_declaration} Debug for {name}{type_parameters_declaration}{type_parameters_constraints} {{
#[allow(dead_code, deprecated)]
Expand All @@ -94,13 +94,13 @@ where
for field in decl.fields.iter() {
fields.push_str(&format!(
".field(\"{field_name}\", self.{field_name})\n",
field_name = field.name.as_str(),
field_name = field.name.as_raw_ident_str(),
));
}

format!(
"_f.debug_struct(\"{}\"){fields}.finish();",
decl.name().as_str()
decl.name().as_raw_ident_str()
)
}

Expand All @@ -126,13 +126,13 @@ where
}

fn generate_fmt_enum_body(&self, engines: &Engines, decl: &TyEnumDecl) -> String {
let enum_name = decl.call_path.suffix.as_str();
let enum_name = decl.call_path.suffix.as_raw_ident_str();

let arms = decl
.variants
.iter()
.map(|variant| {
let variant_name = variant.name.as_str();
let variant_name = variant.name.as_raw_ident_str();
if engines.te().get(variant.type_argument.type_id()).is_unit() {
format!(
"{enum_name}::{variant_name} => {{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ where

let impl_marker_trait_code = format!(
"#[allow(dead_code, deprecated)] impl{type_parameters_declaration} {marker_trait_name} for {}{type_parameters_declaration}{type_parameters_constraints} {{ }}",
enum_decl.name()
enum_decl.name().as_raw_ident_str()
);

let impl_enum_node = self.parse_impl_trait_to_ty_ast_node(
Expand Down
2 changes: 1 addition & 1 deletion sway-parse/src/keywords.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use sway_types::Spanned;

fn peek_keyword<T: Keyword>(peeker: Peeker<'_>) -> Option<T> {
let ident = peeker.peek_ident().ok()?;
(ident.as_str() == T::AS_STR).then(|| T::new(ident.span()))
(!ident.is_raw_ident() && ident.as_str() == T::AS_STR).then(|| T::new(ident.span()))
}

fn parse_keyword<T: Keyword + Peek>(parser: &mut Parser) -> ParseResult<T> {
Expand Down
10 changes: 10 additions & 0 deletions sway-types/src/ident.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
use crate::{span::Span, Spanned};
use serde::{Deserialize, Serialize};
use std::{
borrow::Cow,
cmp::{Ord, Ordering},
fmt,
hash::{Hash, Hasher},
Expand All @@ -26,6 +27,15 @@ impl BaseIdent {
.unwrap_or_else(|| self.span.as_str())
}

/// Returns the identifier as a string, prefixed with `r#` if it is a raw identifier.
pub fn as_raw_ident_str(&self) -> Cow<str> {
if self.is_raw_ident {
Cow::Owned(format!("r#{}", self.as_str()))
} else {
Cow::Borrowed(self.as_str())
}
}

pub fn is_raw_ident(&self) -> bool {
self.is_raw_ident
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
[[package]]
name = 'reserved_identifiers'
source = 'member'
name = "reserved_identifiers"
source = "member"
dependencies = ["std"]

[[package]]
name = "std"
source = "path+from-root-E00F3FB2E032AF39"
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@ authors = ["Fuel Labs <[email protected]>"]
license = "Apache-2.0"
name = "reserved_identifiers"
entry = "main.sw"
implicit-std = false

[dependencies]
std = { path = "../../../reduced_std_libs/sway-lib-std-core" }
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
cmds = ["forc build --path {root} --release --experimental error_type"]
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@ fn main() {
let mut deref = 0;
let mut true = 0;
let mut false = 0;
let mut panic = 0;
}

Loading
Loading