Skip to content

Add #[error_type] and #[error] attributes #7058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 7, 2025

Conversation

ironcev
Copy link
Member

@ironcev ironcev commented Apr 3, 2025

Description

This PR adds #[error_type] and #[error] attributes to the collection of known attributes, as defined in the ABI Errors RFC.

Additionally, the PR updates the outdated documentation for Attributes and Keywords.

Partially addresses #6765.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@ironcev ironcev temporarily deployed to fuel-sway-bot April 3, 2025 14:53 — with GitHub Actions Inactive
@ironcev ironcev temporarily deployed to fuel-sway-bot April 3, 2025 15:20 — with GitHub Actions Inactive
@ironcev ironcev self-assigned this Apr 3, 2025
@ironcev ironcev added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Apr 3, 2025
@ironcev ironcev marked this pull request as ready for review April 3, 2025 16:39
@ironcev ironcev requested review from a team as code owners April 3, 2025 16:39
@ironcev ironcev enabled auto-merge (squash) April 3, 2025 16:39
@Voxelot Voxelot temporarily deployed to fuel-sway-bot April 4, 2025 02:17 — with GitHub Actions Inactive
Copy link

codspeed-hq bot commented Apr 4, 2025

CodSpeed Performance Report

Merging #7058 will not alter performance

Comparing ironcev/error-type-and-error-attributes (2143a9b) with master (d6410e3)

Summary

✅ 22 untouched benchmarks

@ironcev ironcev temporarily deployed to fuel-sway-bot April 4, 2025 07:54 — with GitHub Actions Inactive
@ironcev ironcev temporarily deployed to fuel-sway-bot April 7, 2025 09:14 — with GitHub Actions Inactive
@ironcev ironcev merged commit c25c5af into master Apr 7, 2025
44 checks passed
@ironcev ironcev deleted the ironcev/error-type-and-error-attributes branch April 7, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants