feat: Allow empty values in sparse merkle trees #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netrome
requested review from
xgreenx,
Dentosal,
MitchTurner and
Voxelot
as code owners
|
Note: Before merging, I want to integrate the change in |
Confirmed now, we should be good to go. |
netrome
force-pushed
the
feature/clnt-1508-sparse-merkle-tree-treats-empty-values-as-deletions-in
branch
from
3ec8f3d to
e62c8a5
Compare
rymnc
approved these changes
Apr 15, 2025
Dentosal
approved these changes
Apr 15, 2025
netrome
deleted the
feature/clnt-1508-sparse-merkle-tree-treats-empty-values-as-deletions-in
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #937
This PR removes the problematic check for empty values in the SMT
updatefunction (and the equivalent filtering infrom_set). This makes SMTs able to commit to empty values, which we need for the proof system for theProcessedTransactionstable.Additionally, to better reflect the behavior I renamed the
updatemethod toinsert.