Skip to content

feat: enhance sign functionality with HashableMessage support #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: enhance sign functionality with HashableMessage support #506

wants to merge 10 commits into from

Conversation

nelitow
Copy link
Contributor

@nelitow nelitow commented Apr 9, 2025 •
edited
Loading

  • Closes FE-1482

Summary

Allow the signature of HashableMessages
image

Related: FuelLabs/fuels-wallet#1899

Checklist

  • I've added error handling for all actions/requests, and verified how this error will show on UI. (or there was no error handling)
  • I've reviewed all the copy changed/added in this PR, using AI if needed. (or there was no copy changes)
  • I've included the reference to the issues being closed from Github and/or Linear (or there was no issues)
  • I've changed the Docs to reflect my changes (or it was not needed)
  • I've put docs links where it may be helpful (or it was not needed)
  • I checked the resulting UI both in Light and Dark mode (or no UI changes were made)
  • I reviewed the entire PR myself (preferably, on GH UI)

@nelitow
feat: enhance sign functionality with HashableMessage support
de5bac3 
- Updated the Sign component to handle HashableMessage objects for signing.
- Introduced a new DEFAULT_OBJECT for signing, improving the user experience.
- Modified the signMessage method in multiple connectors to accept both string and HashableMessage types.
- Improved UI layout for signing messages and objects, ensuring better usability.
@vercel Vercel
Copy link

vercel bot commented Apr 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 7:01pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025 •
edited
Loading

Coverage Report for Fuel Wallet (./packages/fuel-wallet)

Status Category Percentage Covered / Total
🔵 Lines 60.9% 148 / 243
🔵 Statements 60.9% 148 / 243
🔵 Functions 53.33% 16 / 30
🔵 Branches 77.77% 21 / 27
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/fuel-wallet/src/FuelWalletConnector.ts 58.69% 76.92% 53.33% 58.69% 72-79, 83-90, 94, 98-99, 102-103, 106-113, 116-117, 120-127, 130-134, 137-146, 154-155, 159-164, 193-194, 221-222, 241-242, 248-265, 287-288, 305-312
Generated in workflow #1567 for commit d6a1ec6 by the Vitest Coverage Report Action

@nelitow nelitow self-assigned this Apr 10, 2025
@nelitow nelitow mentioned this pull request Apr 10, 2025
Open
7 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025 •
edited
Loading

Coverage Report for Fuel Development Wallet (./packages/fuel-development-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 18 / 18
🔵 Statements 100% 18 / 18
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1567 for commit d6a1ec6 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025 •
edited
Loading

Coverage Report for Fuelet Wallet (./packages/fuelet-wallet)

Status Category Percentage Covered / Total
🔵 Lines 34.52% 29 / 84
🔵 Statements 34.52% 29 / 84
🔵 Functions 12.5% 1 / 8
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1567 for commit d6a1ec6 by the Vitest Coverage Report Action

@nelitow nelitow marked this pull request as ready for review April 10, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@pedronauck pedronauck Awaiting requested review from pedronauck pedronauck is a code owner

@LuizAsFight LuizAsFight Awaiting requested review from LuizAsFight LuizAsFight is a code owner

@helciofranco helciofranco Awaiting requested review from helciofranco helciofranco is a code owner

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas rodrigobranas is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@nelitow nelitow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelitow @LuizAsFight