Skip to content

feat: Validate signatures in Solana connector #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: Validate signatures in Solana connector #502

wants to merge 15 commits into from

Conversation

nelitow
Copy link
Contributor

@nelitow nelitow commented Mar 24, 2025 •
edited
Loading

List the issues this PR closes in a bullet list format, e.g.:

  • Closes FE-1521

Summary

Checklist

  • I've added error handling for all actions/requests, and verified how this error will show on UI. (or there was no error handling)
  • I've reviewed all the copy changed/added in this PR, using AI if needed. (or there was no copy changes)
  • I've included the reference to the issues being closed from Github and/or Linear (or there was no issues)
  • I've changed the Docs to reflect my changes (or it was not needed)
  • I've put docs links where it may be helpful (or it was not needed)
  • I checked the resulting UI both in Light and Dark mode (or no UI changes were made)
  • I reviewed the entire PR myself (preferably, on GH UI)

@vercel Vercel
Copy link

vercel bot commented Mar 24, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ❌ Failed (Inspect) Apr 15, 2025 5:41pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025 •
edited
Loading

Coverage Report for Fuel Wallet (./packages/fuel-wallet)

Status Category Percentage Covered / Total
🔵 Lines 61.57% 149 / 242
🔵 Statements 61.57% 149 / 242
🔵 Functions 53.33% 16 / 30
🔵 Branches 83.33% 20 / 24
File CoverageNo changed files found.
Generated in workflow #1561 for commit 15a1da0 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025 •
edited
Loading

Coverage Report for Fuel Development Wallet (./packages/fuel-development-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 19 / 19
🔵 Statements 100% 19 / 19
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1561 for commit 15a1da0 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025 •
edited
Loading

Coverage Report for Fuelet Wallet (./packages/fuelet-wallet)

Status Category Percentage Covered / Total
🔵 Lines 36.78% 32 / 87
🔵 Statements 36.78% 32 / 87
🔵 Functions 12.5% 1 / 8
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #1561 for commit 15a1da0 by the Vitest Coverage Report Action

@nelitow
refactor: streamline signature validation process in SolanaConnector
1afd433 
- Introduced a constant for signature validation key generation.
- Enhanced connection logic to only emit connected event if the account has been validated.
- Improved error handling during signature requests and account validation.
- Updated local storage interactions for better clarity and consistency.
@nelitow nelitow self-assigned this Mar 24, 2025
@nelitow
refactor: streamline signature validation process in SolanaConnector
39fa3c1 
- Introduced a constant for signature validation key generation.
- Enhanced connection logic to only emit connected event if the account has been validated.
- Improved error handling during signature requests and account validation.
- Updated local storage interactions for better clarity and consistency.

audit
@nelitow nelitow force-pushed the nj/feat/presign-on-solana branch from f3ddae4 to 39fa3c1 Compare March 24, 2025 20:57
@FuelLabs FuelLabs deleted a comment from fuel-cla-bot bot Mar 24, 2025
@nelitow nelitow marked this pull request as ready for review March 25, 2025 13:27
@nelitow
feat: implement direct signature validation in SolanaConnector
d90ec5f 
- Added event handling for signature validation based on connection status.
- Enhanced connection logic to check for pending signatures and request validation directly from the provider.
- Improved error handling during signature requests and account validation.
- Removed the deprecated requestSignature method for cleaner code.
@nelitow
chore: update package dependencies in package.json and pnpm-lock.yaml
13d0706 
- Added support for vite version 6.0.12 in package.json and pnpm-lock.yaml.
- Updated postcss version from 8.5.1 to 8.5.3 across multiple dependencies for consistency.
- Adjusted various dependency versions to ensure compatibility and stability.
@nelitow nelitow changed the title feat: enhance SolanaConnector with signature validation feat: Validate signatures in Solana connector Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuizAsFight LuizAsFight LuizAsFight requested changes

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@pedronauck pedronauck Awaiting requested review from pedronauck pedronauck is a code owner

@helciofranco helciofranco Awaiting requested review from helciofranco helciofranco is a code owner

@arthurgeron arthurgeron Awaiting requested review from arthurgeron

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas rodrigobranas is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@nelitow nelitow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelitow @LuizAsFight