Skip to content

feat: add Arcana Wallet connector #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

shrinathprabhu
Copy link

@shrinathprabhu shrinathprabhu commented Feb 11, 2025

Summary

Adds connector for Arcana Wallet (https://arcana.network)

Checklist

  • I've added error handling for all actions/requests, and verified how this error will show on UI. (or there was no error handling)
  • I've reviewed all the copy changed/added in this PR, using AI if needed. (or there was no copy changes)
  • I've included the reference to the issues being closed from Github and/or Linear (or there was no issues)
  • I've changed the Docs to reflect my changes (or it was not needed)
  • I've put docs links where it may be helpful (or it was not needed)
  • I checked the resulting UI both in Light and Dark mode (or no UI changes were made)
  • I reviewed the entire PR myself (preferably, on GH UI)

Copy link

vercel bot commented Feb 11, 2025

@shrinathprabhu is attempting to deploy a commit to the Fuel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@fuel-cla-bot
Copy link

fuel-cla-bot bot commented Feb 11, 2025

Thanks for the contribution! Before we can merge this, we need @shrinathprabhu to sign the Fuel Labs Contributor License Agreement.

@shrinathprabhu shrinathprabhu changed the title Add arcana wallet connector Add Arcana Wallet connector Feb 11, 2025
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2025 3:19am

@helciofranco helciofranco changed the title Add Arcana Wallet connector feat: add Arcana Wallet connector Feb 12, 2025
@fuel-cla-bot
Copy link

fuel-cla-bot bot commented Feb 24, 2025

Thanks for the contribution! Before we can merge this, we need @svarcoder to sign the Fuel Labs Contributor License Agreement.

Copy link
Member

@helciofranco helciofranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERR_PNPM_LOCKFILE_MISSING_DEPENDENCY  Broken lockfile: no entry for '[email protected]' in pnpm-lock.yaml

Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey thanks for the contribution looking forward to have this connector ready to improve UX for fuel users!!

I was checking on the test link and couldn't fully test it, are you guys using the preview link to test if the connector is functional? I got locked on this screen to switch network, the wallet doesnt take any action when I click on it

image

@LuizAsFight
Copy link
Contributor

LuizAsFight commented Mar 12, 2025

after each commit you will have a new preview link to be able to check your latest changes:
image

@LuizAsFight LuizAsFight reopened this Mar 12, 2025
@LuizAsFight
Copy link
Contributor

in case you want to run the examples project locally :
1- copy/paste from the examples/react-app/.env.example and create a .env
2- set VITE_FUEL_PROVIDER_URL=https://testnet.fuel.network/v1/playground
3- set VITE_CHAIN_ID_NAME=testnet
4- run pnpm install
5- run pnpm build
6- run pnpm dev:examples:react

Done you should have the examples app running on localhost:5173

@shrinathprabhu
Copy link
Author

shrinathprabhu commented Mar 13, 2025

hey thanks for the contribution looking forward to have this connector ready to improve UX for fuel users!!

I was checking on the test link and couldn't fully test it, are you guys using the preview link to test if the connector is functional? I got locked on this screen to switch network, the wallet doesnt take any action when I click on it

image

Yeah @LuizAsFight , our wallet doesn't support testnet networks for now, but I'll add support for Fuel Switch network feature, so the preview link works fine

@LuizAsFight
Copy link
Contributor

LuizAsFight commented Apr 4, 2025

I was testing here and detected some issues in the wallet itself (looks to not be in the connector):

  • on review screen, a simple transfer is showing one operation from the account to the account itself (maybe this is the change output?)
    image
  • on review screen, when doing a contract call, it's missing the contract call itself, instead its only showing the change output
    image
  • after clicking on "switch network" it got stuck on the popup even after I clicked multiple times. by refreshing the page I realized that the wallet actually changed to testnet network, it just didn't close the switch network popup

for this one I was only able to make it happen once:

  • after clicking on submit got this error (maybe estimation error on arcana wallet side?)
    image
    image

@LuizAsFight
Copy link
Contributor

another suggestion (but not a blocker for this PR) is:

  • when we connect 2 different accounts, and the user change the account inside of arcana wallet, you can send an event to let the connectors know and switch the account on dapp side as well (you can see one example of how this is done on fuel wallet here
Screen.Recording.2025-04-04.at.02.15.24.mov

Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my only real concern on this PR is about the review screen that needs to improve to show correct information for the user

@shrinathprabhu have any ETA on the fixes on review screen? the others I mentioned are not blockers for this pr

@shrinathprabhu
Copy link
Author

@LuizAsFight I'll add it this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants