Support for JWT Bearer #79
Conversation
…wt-bearer-12 Please note, http://tools.ietf.org/html/draft-ietf-oauth-v2-20#section-4.5 refers to a URI which is defined as a URL or URN http://www.rfc-editor.org/rfc/rfc3305.txt
|
See Issue #78 |
|
Looks good. |
|
@alanbem It would be great to merge this! |
|
@Ener-Getick can you merge and tag this PR? |
| @@ -1001,8 +997,7 @@ protected function grantAccessTokenExtension(IOAuth2Client $client, array $input | |||
| if (!($this->storage instanceof IOAuth2GrantExtension)) { | |||
| throw new OAuth2ServerException(self::HTTP_BAD_REQUEST, self::ERROR_UNSUPPORTED_GRANT_TYPE); | |||
| } | |||
| $uri = filter_var($inputData["grant_type"], FILTER_VALIDATE_URL); | |||
There was a problem hiding this comment.
URN is valid URL so should work with it
There was a problem hiding this comment.
You may check both URI and URN.
A regex pattern for URN could be something like ^urn:[a-z0-9][a-z0-9-]{0,31}:[a-z0-9()+,\-.:=@;$_!*'%/?#]+$
There was a problem hiding this comment.
Wouldn't it be better to do:
if (false === strpos($inputData['grant_type'], 'urn') {
$uri = filter_var($inputData["grant_type"], FILTER_VALIDATE_URL);
}?
There was a problem hiding this comment.
@turneliusz actually, it doesn't work https://secure.php.net/manual/fr/filter.filters.validate.php#110411
|
Can you add a test case to be sure this works as expected please? |
…tension grant types, added unit test for urn access token
|
Added test case and restored the |
|
Looking forward, thanks @kralos ! |
https://tools.ietf.org/html/draft-ietf-oauth-jwt-bearer-12
Please note, http://tools.ietf.org/html/draft-ietf-oauth-v2-20#section-4.5 refers to a URI which is defined as a URL or URN http://www.rfc-editor.org/rfc/rfc3305.txt