Skip to content

Use github action, remove travis, drop phpunit 4 support and support PHP 8.0 #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 6, 2021

Conversation

vasilvestre
Copy link

@vasilvestre vasilvestre commented Mar 27, 2021

Ok so, I went too far :

"phpunit/phpunit" ^4.8 can't work anymore, all test are now 6.0+ compatible

FIx #127 and fix #123 and fix #126

Tests passes but I'm not sure it's still working, any help is welcome

@vasilvestre vasilvestre marked this pull request as draft March 27, 2021 22:20
@vasilvestre vasilvestre mentioned this pull request Mar 27, 2021
@vasilvestre vasilvestre marked this pull request as ready for review March 27, 2021 22:52
@vasilvestre vasilvestre changed the title Use github action and remove travis Use github action, remove travis, drop phpunit 4 support and support PHP 8.0 Mar 27, 2021
@GuilhemN
Copy link
Member

Wow that was fast!
Thanks a lot, this is all good for me 👍

@vasilvestre
Copy link
Author

Wow that was fast!
Thanks a lot, this is all good for me 👍

Great ! Any release would be adopted through OSS PR I'm actually working on :)

@vasilvestre
Copy link
Author

I've uncommented push action. Feel free to add a readme badge :)

@GuilhemN GuilhemN merged commit 546f869 into FriendsOfSymfony:master Apr 6, 2021
@GuilhemN
Copy link
Member

GuilhemN commented Apr 6, 2021

Thank you @vasilvestre!

@vasilvestre
Copy link
Author

Any release date planned ?

@GuilhemN
Copy link
Member

GuilhemN commented Apr 6, 2021

It's released https://github.com/FriendsOfSymfony/oauth2-php/releases/tag/1.3.1 😉

@vasilvestre vasilvestre deleted the ci branch April 6, 2021 19:37
@vasilvestre vasilvestre mentioned this pull request Apr 7, 2021
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Github Action Quit PHPUNIT 4 PHP 8 support
2 participants