[Extended] Add symfony 3.0 support #374
Conversation
|
@stof @willdurand can you take a look at this please? ping @luispabon |
|
@Spomky this can be reverted once a new version of |
| $this->request->query->all() | ||
| )); | ||
| try { | ||
| $request = $this->container->get('request_stack')->getCurrentRequest(); |
There was a problem hiding this comment.
Request stack is not available in 2.3
|
Once there is a stable release of oauth2-php that can be depended upon, 👍 |
|
Definitely need oauth2-php released, depending on dev is iffy at best. |
|
@luispabon moreover the bundle won't be completely compatible with sf 3 except if the final user also uses the dev version of |
|
Yes, indeed. I wonder why a new release hasn't been cut yet. |
| "friendsofsymfony/oauth2-php": "~1.1.0", | ||
| "symfony/framework-bundle": "~2.2", | ||
| "symfony/security-bundle": "~2.1" | ||
| "friendsofsymfony/oauth2-php": "~1.1", |
There was a problem hiding this comment.
@Ener-Getick seems like you already released oauth2-php 1.2 compatible with symfony/http-foundation 3?
There was a problem hiding this comment.
Yeah, I'm just updating several part of the code to not introduce BC breaks.
|
I'll create |
|
👍 You joined FOS then? |
|
Awesome 👍 |
|
Any idea why travis doesn't launch the builds? |
|
It does, but it takes quite some time for them to clear through the queue. Travis could do with a little more capacity. |
|
Ah yeah just when I post a message they are launched ^^ |
|
@Ener-Getick https://www.traviscistatus.com/incidents/pfcclfpffppn 😕 |
|
@j0k3r ah right thanks! I'll disable |
[Extended] Add symfony 3.0 support
|
The build failure is related to https://www.traviscistatus.com/incidents/pfcclfpffppn so I merge this PR. |
This PR is based on #371 and only fixes the tests.
Happy new year!
Closes #371
Closes #366