Migrate TopNav to the composition API #7227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 18, 2025
PikachuEXE
approved these changes
Apr 19, 2025
kommunarr
approved these changes
Apr 19, 2025
github-actions
bot
removed
the
PR: waiting for review
OothecaPickle
added a commit
to OothecaPickle/FreeTube
that referenced
this pull request
Apr 29, 2025
This reverts commit 89dea10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate TopNav to the composition API
Pull Request Type
Description
This pull request migrates the
TopNavcomponent to the composition API. Apart from the migration this pull request also includes a few other changes, such as moving the CTRL/CMD+L and ALT+D keyboard shortcuts and search input text handling from theAppcomponent into theTopNavcomponent to avoid needing to usedefineExpose()and refs.Testing
Test the functionality of the top nav, from searching and search suggestions to navigating back and forth and the navigation history menus to the keyboard shortcuts that focus the search bar.
Desktop