Allow legacy formats to be used even when dash and audio-only are unavailable #6977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Mar 5, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Mar 8, 2025
ChunkyProgrammer
approved these changes
Mar 8, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Mar 11, 2025
* development: (97 commits) Translated using Weblate (German) Translated using Weblate (Czech) Translated using Weblate (Basque) Translated using Weblate (Hungarian) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Japanese) Translated using Weblate (Estonian) Translated using Weblate (Portuguese (Brazil)) Bump the eslint group with 4 updates (FreeTubeApp#6985) Add support for channel's `Courses` tab (FreeTubeApp#6641) Bump electron from 34.3.0 to 35.0.1 (FreeTubeApp#6986) Bump shaka-player from 4.13.6 to 4.13.8 (FreeTubeApp#6990) Bump css-minimizer-webpack-plugin from 7.0.0 to 7.0.2 (FreeTubeApp#6988) Bump swiper from 11.2.4 to 11.2.5 (FreeTubeApp#6989) Bump lefthook from 1.11.2 to 1.11.3 (FreeTubeApp#6987) Update Invidious DASH xtags handling for YouTube.js changes (FreeTubeApp#6944) Translated using Weblate (French) Allow legacy formats to be used even when dash and audio-only are unavailable (FreeTubeApp#6977) Translated using Weblate (Hungarian) Fix search not working on mobile because of undefined ref (FreeTubeApp#6706) ...
efb4f5ff-1298-471a-8973-3d47447115dc
pushed a commit
that referenced
this pull request
Mar 26, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
pushed a commit
to efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube
that referenced
this pull request
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow legacy formats to be used even when dash and audio-only are unavailable
Pull Request Type
Description
Currently when FreeTube receives a SABR-only response from YouTube we get a
No valid URL to deciphererror from the local API and then try falling back to the Invidious API which will fail unless the user is running their own Invidious instance and has configured it in the FreeTube settings. As the legacy format 360p stream is still available in those responses, this pull request makes sure that it can still be used even when the URLs are missing for the DASH streams.While the goal is still to add SABR support to FreeTube, this allows people to still watch videos in the mean time, even if it is at a low quality.
Testing
You can replicate a SABR-only response by adding
info.streaming_data.adaptive_formats.forEach(f => { f.url = undefined })just inside theif (info.streaming_data) {line insrc/renderer/helpers/api/local.js.Check that the legacy formats get selected automatically, you can't switch to DASH or audio-only and the downloads menu only lists the subtitles and the legacy format stream.
Desktop