Use numbers instead of strings for the DBActions and SyncEvents constants

[absidue]

Use numbers instead of strings for the DBActions and SyncEvents constants

Pull Request Type

• Performance improvement

Description

Currently we use string values in our DBActions and SyncEvents constants. While there is nothing wrong with doing that, there are definitely a few advantages, such how long some of the strings have become e.g. sync-subscriptions-update-shorts-with-channel-page-shorts-by-channel.

It is a well known fact that computers are great at crunching numbers, so switching to number values should not only be more performant but will also lower memory use and the bundle sizes (-1379 bytes from both the main.js and renderer.js files).

From a development perspective this shouldn't have a big impact as we still have the human readable variable names and there is a code comment explaining that the numbers need to be unique/not overlap, so I don't think this will impact maintainance too much.

If you are wondering why I didn't do the same to the IpcConstants, it is because Electron requires string values for the IPC channel names.

Testing

1. Open multiple windows
2. Check that changing a setting, modifying playlists and refreshing subscriptions for example get synced properly between windows. That tests that they arrived correctly in the main process via the DBActions constants and got forwarded to the other window with the SyncEvents constants.

Desktop

• OS: Windows
• OS Version: 10
• FreeTube version: 0464d90

[PikachuEXE]

I think it's easer to start other groups on 11 or even 101 so that if a few things are added to GENERAL there is no need to reassign values for other groups

[absidue]

I've bumped the numbering for the other categories to start at 20, that gives us 14 more spots in the DBActions and 15 in the SyncEvents constants. Which leaves us a decent amount of flexibility without chosing numbers that are unnecessarily large.