Skip to content

Fix tap to seek not using skip interval setting #6288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Dec 6, 2024

Fix tap to seek not using skip interval setting

Pull Request Type

  • Bugfix

Related issue

Description

This pull request fixes the tap to seek feature not using the configured skip interval, I consider this a bug fix and not a feature implementation, as it is expected behaviour and this is a regression compared to what we were doing for video.js. Seeking with the keyboard arrow keys multiplies the skip interval with the playback rate, I decided not to do that for the touch controls, as shaka-player recreates the entire UI every time you call configure, so if we had to do it every time the user changed the playback rate that wouldn't be a great experience, additionally as you can see from the code snippet linked below, we didn't use the playback rate for the touch controls with video.js either.

touchControls: {
seekSeconds: this.defaultSkipInterval,
tapTimeout: 300
}

Testing

  1. Enable the mobile emulation in the dev tools
  2. Then open a video (the order of these two steps is important, as shaka-player won't activate the tap to seek feature if it doesn't detect touch support)
  3. Open a second window to the settings page
  4. Test various default skip interval values to check that the player uses your configured value

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: b4217ef

@FreeTubeBot FreeTubeBot merged commit ed9542f into FreeTubeApp:development Dec 6, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 6, 2024
@absidue absidue deleted the tap-seek-interval branch December 7, 2024 00:18
jlvivero pushed a commit to jlvivero/FreeTube that referenced this pull request Dec 7, 2024
SuperAKWA pushed a commit to SuperAKWA/FreeTube that referenced this pull request Jan 24, 2025
OothecaPickle pushed a commit to OothecaPickle/FreeTube that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants