Fix tap to seek not using skip interval setting #6288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tap to seek not using skip interval setting
Pull Request Type
Related issue
Description
This pull request fixes the tap to seek feature not using the configured skip interval, I consider this a bug fix and not a feature implementation, as it is expected behaviour and this is a regression compared to what we were doing for video.js. Seeking with the keyboard arrow keys multiplies the skip interval with the playback rate, I decided not to do that for the touch controls, as shaka-player recreates the entire UI every time you call
configure
, so if we had to do it every time the user changed the playback rate that wouldn't be a great experience, additionally as you can see from the code snippet linked below, we didn't use the playback rate for the touch controls with video.js either.FreeTube/src/renderer/components/ft-video-player/ft-video-player.js
Lines 474 to 477 in 8b66548
Testing
Desktop