Skip to content

Fix user playlist z-index issue #5177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2024
Merged

Fix user playlist z-index issue #5177

merged 2 commits into from
May 27, 2024

Conversation

kommunarr
Copy link
Collaborator

Fix user playlist z-index issue

Pull Request Type

  • Bugfix

Related issue

#4949 (comment)

Description

[weeps silently at another z-index issue]

Testing

  • Test that video progress bar does not poke in front of the user playlist grid view top section

Desktop

  • OS: OpenSUSE
  • OS Version: TW

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 26, 2024 22:35
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 26, 2024
PikachuEXE
PikachuEXE reviewed May 27, 2024
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment to explain the value (e.g. video progress bar has z-index 2 and this must be above it)

kommunarr
kommunarr commented May 27, 2024
View reviewed changes
PikachuEXE
PikachuEXE previously approved these changes May 27, 2024
View reviewed changes
@PikachuEXE
Copy link
Collaborator

Oh no~
image

@kommunarr kommunarr force-pushed the fix/z-index-playlist branch from a8c5e37 to d2f7b4d Compare May 27, 2024 02:58
@kommunarr kommunarr requested a review from PikachuEXE May 27, 2024 03:00
@kommunarr
Copy link
Collaborator Author

Note to self: never try to do things through the GH UI and hope it works out lol

@FreeTubeBot FreeTubeBot merged commit c5a8e5c into FreeTubeApp:development May 27, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kommunarr @PikachuEXE @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @FreeTubeBot