-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Use playlist name for playlist page title #5150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use playlist name for playlist page title #5150
Conversation
Can we update text for Also we should prevent long titles like existing logic titleForDisplay: function () {
if (typeof this.title !== 'string') { return '' }
if (this.title.length <= 255) { return this.title }
return `${this.title.substring(0, 255)}...`
}, |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This one isn't as straightforward. "Your playlists" conveys the playlists you own. "Your Playlists" conveys the section containing the playlists you own.
How about constraining the user playlist name length (video title length is already restricted by YT)? Can do this in a separate PR if desired. |
…at/add-playlist-name-to-title
Conflicts have been resolved. A maintainer will review the pull request shortly. |
No I only mean the one in
Please do |
Oh, I didn't catch that. Yeah, |
* development: Update playlist name with title (FreeTubeApp#5150) User playlists as grid (FreeTubeApp#4949) Add custom webpack loader to remove unused mimetypes from mime-db (FreeTubeApp#5148) ^ Update GH action eps1lon/actions-label-merge-conflict (FreeTubeApp#5034) Translated using Weblate (Italian) Translated using Weblate (Serbian) Translated using Weblate (Estonian) Translated using Weblate (Bulgarian) Translated using Weblate (Spanish) Translated using Weblate (Italian) Translated using Weblate (Polish) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (French) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Chinese (Simplified)) Fix gap next to banner when Hide Side Bar Labels is enabled (FreeTubeApp#5120)
@PikachuEXE @jasonhenriquez That string is correct. Using title case is an American English thing, British English uses sentence case a lot more. |
Use playlist name for playlist page title
Pull Request Type
Related issue
#4949 (comment)
Description
Sets document title to playlist title. This is consistent with how we do it for other routes with custom named content, YT, and user expectations.
Screenshots
Testing
Desktop