Skip to content

Use Swiper instead of TinySlider #4427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ChunkyProgrammer
Copy link
Member

Use Swiper instead of TinySlider

Pull Request Type

  • Other - development chore, requirement for vue3 migration

Related issue

https://github.com/FreeTubeApp/FreeTube/projects/10#card-87323330

Description

Migrate from TinySlider to Swiper

Screenshots

Before:
image

After:
image

Testing

  • go to mr beast's channel
  • look at community tab
  • try swiping on multi image post

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.19.1

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 6, 2023 21:35
@github-actions github-actions bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Dec 6, 2023
@absidue
Copy link
Member

absidue commented Dec 7, 2023

Looks like there is no way to navigate with the keyboard only.

@ChunkyProgrammer
Copy link
Member Author

ChunkyProgrammer commented Dec 8, 2023

Looks like there is no way to navigate with the keyboard only.

tabbing to it works for me (then pressing enter).

image

@FreeTubeBot FreeTubeBot merged commit d6a6cc0 into FreeTubeApp:development Dec 8, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 8, 2023
@ChunkyProgrammer ChunkyProgrammer deleted the swiperjs-migration branch December 8, 2023 19:27
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Dec 9, 2023
* development:
  split electron-builder config to a separate file from build script (FreeTubeApp#4431)
  Translated using Weblate (Ukrainian)
  use swiper.js instead of tinyslider (FreeTubeApp#4427)
  Translated using Weblate (Welsh)
  Added translation using Weblate (Welsh)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Finnish)
  Translated using Weblate (Hungarian)
  Various small watch page changes (FreeTubeApp#4423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants