-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement right-to-left interface #3970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FreeTubeBot
merged 69 commits into
FreeTubeApp:development
from
kommunarr:add-rtl-support
Sep 9, 2023
Merged
Changes from 66 commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
538884b
Replace margin-left with margin-inline-start
kommunarr ed1836a
Replace margin-right with margin-inline-end
kommunarr 5dc8303
Replace padding-left with padding-inline-start
kommunarr 215ae66
Replace padding-right with padding-inline-end
kommunarr 1bee690
Replace padding-top & padding-bottom with padding-block; continue rep…
kommunarr 0fa5a5f
Add updated rtl-compatible margins to ft-slider and fix indentation
kommunarr c88f916
Replace margin-top & margin-bottom with margin-block; continue replac…
kommunarr 7509ef1
Continue replacing with margin-block and margin-inline
kommunarr 0b06cb1
Replace left and right with inset-inline-start and inset-inline-end
kommunarr d73c9ee
Replace margin-bottom, top, and bottom with margin-block-end, inset-b…
kommunarr 127ee1a
Replace text-align left and right with text-align start and end
kommunarr 3fe7977
Fix syntax error with inset-block-end
kommunarr 6de06bb
Implement dynamic float: left/right based on direction ltr/rtl
kommunarr a95d32c
Implement dynamic navigation arrow placement based on direction ltr/rtl
kommunarr 3f5539a
Add direction to body based on preferred language
kommunarr 5f29208
Implement horizontal directionality coefficient to fix translate work…
kommunarr eb6169c
Add explicit text-align: start in places to ensure rtl version is cor…
kommunarr e2e7bfb
Add text-align: start to places where it is not inferred to enable pr…
kommunarr 245c811
Fix search bar magnifying glass being too far right issue
kommunarr 32b3473
Move body.dir-setting logic to setLocale to fix dir not setting corre…
kommunarr fe8f397
Change .switchColumn to have align-items: start instead of justify-it…
kommunarr 5325cc2
Fix emergent bug in which history icons are temporarily disabled on c…
kommunarr 251cde5
Add Kurdish to rtl languages list & add li items to be right-aligned …
kommunarr b38c586
Force FreeTube logo to be ordered left-to-right for 'brand consistency'
kommunarr d221f43
Add styling flipping font-awesome icons for rtl languages except for …
kommunarr b8462cc
Update isRightAligned with additional languages, and use it instead o…
kommunarr 03648af
Update isRightAligned property name to more clearly reflect rtl purpose
kommunarr a16c7f7
Simplify left/right arrow display logic
kommunarr a96fc0c
Replace justify-self: left & justify-self: right with justify-self; s…
kommunarr a9d1937
Remove misguided attempt to emulate directionality-agnosticism with r…
kommunarr e6a8b5c
Explicitly center FreeTube version on About page
kommunarr 83db9b6
Replace pre-existing identation issue
kommunarr 2617e7d
Replace margin-left with margin-inline-start
kommunarr bf1c458
Replace margin-right with margin-inline-end
kommunarr 594adb8
Replace padding-left with padding-inline-start
kommunarr 0427cee
Replace padding-right with padding-inline-end
kommunarr 68a00a8
Replace padding-top & padding-bottom with padding-block; continue rep…
kommunarr c70a511
Add updated rtl-compatible margins to ft-slider and fix indentation
kommunarr d7cf402
Replace margin-top & margin-bottom with margin-block; continue replac…
kommunarr f2a0385
Continue replacing with margin-block and margin-inline
kommunarr 9558f61
Replace left and right with inset-inline-start and inset-inline-end
kommunarr b07a378
Replace margin-bottom, top, and bottom with margin-block-end, inset-b…
kommunarr fa2cba3
Replace text-align left and right with text-align start and end
kommunarr 31729e6
Fix syntax error with inset-block-end
kommunarr 08a0a5f
Implement dynamic float: left/right based on direction ltr/rtl
kommunarr 03542be
Implement dynamic navigation arrow placement based on direction ltr/rtl
kommunarr b97480f
Add direction to body based on preferred language
kommunarr b73220e
Implement horizontal directionality coefficient to fix translate work…
kommunarr c20e834
Add explicit text-align: start in places to ensure rtl version is cor…
kommunarr b46e92b
Add text-align: start to places where it is not inferred to enable pr…
kommunarr 64e69f0
Fix search bar magnifying glass being too far right issue
kommunarr cdcbc08
Move body.dir-setting logic to setLocale to fix dir not setting corre…
kommunarr e152e4e
Change .switchColumn to have align-items: start instead of justify-it…
kommunarr df5926a
Fix emergent bug in which history icons are temporarily disabled on c…
kommunarr 2fe664a
Add Kurdish to rtl languages list & add li items to be right-aligned …
kommunarr 8f42005
Force FreeTube logo to be ordered left-to-right for 'brand consistency'
kommunarr 3bc31a1
Add styling flipping font-awesome icons for rtl languages except for …
kommunarr ea6405a
Update isRightAligned with additional languages, and use it instead o…
kommunarr 301fe30
Update isRightAligned property name to more clearly reflect rtl purpose
kommunarr d7626c8
Simplify left/right arrow display logic
kommunarr 1f58445
Replace justify-self: left & justify-self: right with justify-self; s…
kommunarr 3d1cdfa
Remove misguided attempt to emulate directionality-agnosticism with r…
kommunarr 812cdee
Explicitly center FreeTube version on About page
kommunarr b9d6bf1
Merge branch 'development' of github.com:FreeTubeApp/FreeTube into ad…
kommunarr c136216
Fix question mark icon orientation in Arabic, Kurdish, Persian, and Urdu
kommunarr 3149c3e
Fix question mark reversing logic for Arabic, Hebrew, Persian, and Urdu
kommunarr 7ed599d
Fix minor indentation issue
kommunarr a97b3fe
Remove unused function
kommunarr 3cee5da
Update src/renderer/components/ft-slider/ft-slider.css
kommunarr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/renderer/components/experimental-settings/experimental-settings.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
.experimental-warning { | ||
text-align: center; | ||
font-weight: bold; | ||
padding-left: 4%; | ||
padding-right: 4% | ||
padding-inline-start: 4%; | ||
padding-inline-end: 4% | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,7 @@ | ||
.ft-card { | ||
background-color: var(--card-bg-color); | ||
margin: 8px; | ||
padding: 16px; | ||
padding-top: 3px; | ||
padding-bottom: 16px; | ||
padding-block: 3px 16px; | ||
padding-inline: 16px; | ||
box-shadow: 0 1px 2px rgba(0,0,0,.1); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.