Upgrade YouTube.js to version 6.0 #3895
Conversation
github-actions
bot
added
PR: dependencies
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
|
Should I build my own version with this PR and use for a few days at least to be sure...? |
|
That would probably be the sensible thing to do yes, buuut more delays :( |
|
I just viewed https://www.youtube.com/watch?v=wUVWuH9RDGQ&list=PL8mG-RkN2uTxUd9RC2bsL1W8Ov-3wAHxv Wrong playlist & channel name & progress...? Edit: Same thing in |
|
That must be a bug with the channel page staying alive between loads (so that we don't need to fetch the playlist again for every video in the same playlist) but i guess it doesn't properly detect if you switch from one playlist directly to a different one. |
|
Probably existed before this pull request. |
|
Not sure if you want to fix that too in this PR (to reduce delay |
|
I'll open a separate pull request, as it can be merged indepentently of this, as long as you only test it with playlists with a single page. |
github-actions
bot
removed
the
PR: waiting for review
* development: Fix playlist view on the watch page not reacting to playlist changes (FreeTubeApp#3897) Bump version number to v0.19.0 Fix linting issues Translated using Weblate (Bulgarian) Ignore broken audio tracks for videos with multiple audio tracks (FreeTubeApp#3851) local API: Add support for PageHeader hashtag header (FreeTubeApp#3896) Translated using Weblate (German) Translated using Weblate (Swedish) Upgrade YouTube.js to version 6.0 (FreeTubeApp#3895) # Conflicts: # src/renderer/components/ft-list-playlist/ft-list-playlist.vue # src/renderer/components/watch-video-playlist/watch-video-playlist.vue
* feature/playlist-2023-05: Fix playlist view on the watch page not reacting to playlist changes (FreeTubeApp#3897) Bump version number to v0.19.0 Fix linting issues Translated using Weblate (Bulgarian) Ignore broken audio tracks for videos with multiple audio tracks (FreeTubeApp#3851) local API: Add support for PageHeader hashtag header (FreeTubeApp#3896) Translated using Weblate (German) Translated using Weblate (Swedish) Upgrade YouTube.js to version 6.0 (FreeTubeApp#3895)
Upgrade YouTube.js to version 6.0
Pull Request Type
Description
This pull request upgrade YouTube.js to version 6 and implements the changes from #3838 on the watch page, as I only did it on the playlist page at the time (yes I forgot to do it on the watch page 🙈).
The YouTube.js upgrade also makes it possible to fix the hashtag header layout change that I noticed in #3886 (will create a separate PR, will need to dig out some visitor data that has the layout change).
None of the breaking changes affect us, they are mostly internal changes, but as YouTube.js exposes all internal functionality, it's possible that other projects were relying on certain things (we don't), which is why they were classified as breaking. To us those changes might even have a positive impact as it now uses less polyfills.
YouTube.js 6 change log: https://github.com/LuanRT/YouTube.js/releases/tag/v6.0.0
The breaking changes in detail: LuanRT/YouTube.js#468
Testing
Playlist with two pages (test on both the watch and playlist pages): https://youtube.com/playlist?list=PLa4zmfXkL4P0RkofW6vbsqhOAKgjwLws1
Watch page for an album playlist (check that the author name shows up and can't be clicked on): https://www.youtube.com/watch?v=WG2nf9IvWVg&list=OLAK5uy_mYnfMbIG74obySLdWtKKGj_MJ-YZqVTu0