Add keyboard shortcuts to jump to the next and previous chapters

[absidue]

Add keyboard shortcuts to jump to the next and previous chapters

Pull Request Type

• Feature Implementation

Related issue

closes #2823

Description

This pull request adds keyboard shortcuts to jump to the next and previous chapters using Option+left arrow and Option+right arrow on macOS and Ctrl+left arrow and Ctrl+right arrow on Windows and Linux, these are the same as on YouTube.

Testing

Watch a video with chapters, e.g. https://youtu.be/OHKKcd3sx2c and test the keyboard shortcuts

Desktop

• OS: Windows
• OS Version: 10
• FreeTube version: 0.18.0

[ChunkyProgrammer]

Could you open a pr on freetubedocs as well?

[PikachuEXE]

What are the keys ._.

[ChunkyProgrammer]

What are the keys ._.

It should be ctrl + Arrow left or ctrl + arrow right

[PikachuEXE]

Testing chars:
Option + < and Option + >
What char did @absidue use to break the display ❓

[PikachuEXE]

Found a problem:
Option + < and Option + > = Prev/Next Page on electron ._.
Pressed Option + <, navigated to previous page

[absidue]

@PikachuEXE looks like Apple OS's don't display those unicode arrow characters.

[absidue]

written out the keys now

[PikachuEXE]

Prev/Next Page on electron problem still valid ._.

[absidue]

@PikachuEXE the problem is caused by this: https://github.com/FreeTubeApp/FreeTube/blob/development/src/renderer/App.js#L296-L303

[PikachuEXE]

How about using Cmd+left arrow and Cmd+right arrow?

[absidue]

Updated the shortcuts code

[PikachuEXE]

Tested MacOS, not tested windows

Update: tested on windows too

[efb4f5ff-1298-471a-8973-3d47447115dc]

Im unable atm to create a PR in the docs repo for this. Could somebody open up a PR to add this shortcut to the docs :)

[PikachuEXE]

FreeTubeApp/FreeTube-Docs#74

Just do (approve) it

[DnickC]

Has this been tested on linux? I'm on mint using release 19.1 and this does not work for me.

[efb4f5ff-1298-471a-8973-3d47447115dc]

It worked on Ubuntu but maybe something broke it?

[kommunarr]

This is still working for me on OpenSUSE. Do you have a particular video link this isn't working for? Also make sure your focus isn't on a particular button, otherwise you may be encountering #4137.