Advertise FT better in README #2677

efb4f5ff-1298-471a-8973-3d47447115dc · 2022-10-04T16:34:51Z

Advertise FT better in README

Pull Request Type

Bugfix
Feature Implementation
Documentation
Other

Description

Notable things that I've done:

Ordered the headings in a more logical structure for readers
removed some sentences that were redundant
removed browser extension disclaimer because the link didn't provide the adequate info anymore and couldn't find a good replacement

Screenshots

I think its better to go to https://github.com/efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube/blob/marketing/README.md

Additional context

Need your help/opinion on:

Did i miss some features that we should definitely list?
Should we update our pictures to show more of our features?
i've made the nighly builds header smaller because it is a subset of the official downloads but the header is now the same size as plain text. Should i revert this change?
Do we want to add badges/widgets in the same way https://github.com/privacyguides/privacyguides.org did above their about header?
Do we want to include the following statement in the extension section?

In order for the extension to work properly, you must be using an installable, non-portable version of FreeTube. This is because non-portable builds do not setup the required protocol needed for your operating system to redirect the URLs over to FreeTube.
The following builds are supported:
.exe
.dmg
.deb
.rpm
Flatpak

Sorry requested your review to help me with the things listed in Additional context section

efb4f5ff-1298-471a-8973-3d47447115dc · 2022-10-05T08:25:07Z

Why nobody reading the Additional context section :(

PikachuEXE · 2022-10-05T08:41:25Z

Did i miss some features that we should definitely list?

Having a Pikachu as developer /s

Should we update our pictures to show more of our features?

No, at most link to a page on docs and update docs website to display images (otherwise this README might become very long)

i've made the nighly builds header smaller because it is a subset of the official downloads but the header is now the same size as plain text. Should i revert this change?

Fine for me ._.

Do we want to add badges/widgets in the same way https://github.com/privacyguides/privacyguides.org did above their about header?

Change welcome but separate PR preferred

Do we want to include the following statement in the extension section?
In order for the extension to work properly, you must be using an installable, non-portable version of FreeTube.

Is it repeatedly asked? If so include it

ChunkyProgrammer · 2022-10-05T17:25:04Z

Not sure about including the screenshot one. It'd definitely a nice to have but it's pretty easy to take a screenshot outside of thevapp (on windows, you just have to do Win + Shift + S and you can select an area to screenshot). Iirc the screenshot only takes a screenshot of the video so maybe that should be included in the line if you still want to keep it?
Tldr: screenshot is cool but it's not really a selling point of freetube

I also think you should include that part in the extension section that says not all builds are supported

ChunkyProgrammer · 2022-10-07T13:12:02Z

README.md

 ## Features
 * Watch videos without ads
 * Use YouTube without Google tracking you using cookies and JavaScript
 * Two extractor APIs to choose from (Built in or Invidious)
 * Subscribe to channels without an account
-* Local subscriptions, history, and saved videos
+* Connect to an externally setup tor proxy


Maybe remove "tor" as the proxy doesn't have to be a tor proxy

Suggestion Connect to an externally setup (tor) proxy

Maybe Connect to an externally setup proxy such as Tor

sound good to me

PikachuEXE · 2022-10-08T03:15:09Z

README.md

+* .deb
+
+* .dmg
+
+* .exe
+
+* Flatpak
+
+* Portable (Windows only)
+
+* .rpm


Why are these so separated?

they need to be removed stop using ur thunderbolt so fast :'(

commit c886559 Merge: f4d73ca 09e61ae Author: Emma <[email protected]> Merge branch 'development' of https://github.com/MarmadileManteater/FreeTubeCordova into development commit f4d73ca Merge: 0e605d9 ae9d329 Author: Emma <[email protected]> Merge 'upstream/development' into development commit ae9d329 Author: atilluF <[email protected]> Translated using Weblate (Italian) commit b2b9d97 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump electron-builder from 23.3.3 to 23.6.0 (FreeTubeApp#2705) commit 3c7b143 Author: Emma <[email protected]> Improving responsiveness in Settings (FreeTubeApp#2694) commit 3af6dd7 Author: Jeff Huang <[email protected]> Translated using Weblate (Chinese (Traditional)) commit b127c85 Author: Eric <[email protected]> Translated using Weblate (Chinese (Simplified)) commit 40859b5 Author: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com> Update index.js (FreeTubeApp#2706) commit 3db62f6 Author: gallegonovato <[email protected]> Translated using Weblate (Spanish) commit b4bfbdc Author: Ihor Hordiichuk <[email protected]> Translated using Weblate (Ukrainian) commit 09e61ae Merge: 0e605d9 bdb8b17 Author: Emma <[email protected]> Merge branch 'FreeTubeApp:development' into development commit 0e605d9 Author: Emma <[email protected]> Removing custom videoJS css which is no longer necessary commit d5bc0cd Merge: ec906ef 687352f Author: Emma <[email protected]> Merge remote-tracking branch 'upstream/development' into development commit ec906ef Merge: e202c79 7ca6440 Author: Emma <[email protected]> Merge branch 'upstream_development' into development commit bdb8b17 Merge: 687352f e64db7f Author: Hosted Weblate <[email protected]> Merge branch 'origin/development' into Weblate. commit e64db7f Author: Oğuz Ersen <[email protected]> Translated using Weblate (Turkish) commit 66e1ff3 Author: Rex_sa <[email protected]> Translated using Weblate (Arabic) commit 687352f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump mikefarah/yq from 4.27.5 to 4.28.1 (FreeTubeApp#2703) commit 1508b05 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump lefthook from 1.1.1 to 1.1.2 (FreeTubeApp#2699) commit b3e0cc3 Author: Preston <[email protected]> Switch token for Flathub deployment commit c63149d Merge: 7fb5d47 f07aefd Author: Hosted Weblate <[email protected]> Merge branch 'origin/development' into Weblate. commit f07aefd Author: gallegonovato <[email protected]> Translated using Weblate (Spanish) commit 7fb5d47 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump yt-channel-info from 3.1.0 to 3.1.1 (FreeTubeApp#2702) commit 5106868 Author: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com> Update report.yml (FreeTubeApp#2704) commit ce24739 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump mini-css-extract-plugin from 2.6.0 to 2.6.1 (FreeTubeApp#2701) commit 48fe90e Merge: 22a5062 03cb0db Author: Hosted Weblate <[email protected]> Merge branch 'origin/development' into Weblate. commit 03cb0db Author: gallegonovato <[email protected]> Translated using Weblate (Galician) commit eeeb903 Author: Florin Voicu <[email protected]> Translated using Weblate (Romanian) commit 74f57b7 Author: HexagonCDN <[email protected]> Translated using Weblate (Vietnamese) commit 22a5062 Author: absidue <[email protected]> Move calculateColorLuminance, calculatePublishedDate and buildVTTFileLocally out of the store (FreeTubeApp#2692) commit 7ca6440 Author: Aiz <[email protected]> Add shortcuts for refresh buttons on Subscription, Trending, and Popular views (FreeTubeApp#2689) commit aa4a01b Author: absidue <[email protected]> Cleanup the web webpack config (FreeTubeApp#2690) commit 41fee01 Author: ChunkyProgrammer <[email protected]> Improve Importing Subscriptions (FreeTubeApp#2604) commit 2154255 Author: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com> Advertise FT better in README (FreeTubeApp#2677) **Full Changelog**: 0.17.1-nightly-66...0.17.1-nightly-67

efb4f5ff-1298-471a-8973-3d47447115dc added 10 commits October 3, 2022 23:59

logical structure

e7bef21

swap headings

7240789

remove redundant info

c9e6276

remove disclaimer

3c31d76

concrete wording

2d38486

swap nightly and unofficial

eb449ea

smaller header

1e79ad0

redirect users to discussions

3c7f328

list chapters as feature

a5c2f8d

update localization image

2b712d9

github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 4, 2022

PrestonN enabled auto-merge (squash) October 4, 2022 16:35

Merge branch 'development' into marketing

0ab37b1

efb4f5ff-1298-471a-8973-3d47447115dc mentioned this pull request Oct 4, 2022

Browser extension update FreeTubeApp/FreeTube-Docs#46

Merged

efb4f5ff-1298-471a-8973-3d47447115dc requested review from absidue, ChunkyProgrammer and PikachuEXE October 4, 2022 16:46

absidue previously approved these changes Oct 4, 2022

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc added PR: WIP and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Oct 4, 2022

efb4f5ff-1298-471a-8973-3d47447115dc added 2 commits October 4, 2022 17:03

added some features

58fb056

more features and reordering

b54cf60

efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 4, 2022

PikachuEXE previously approved these changes Oct 5, 2022

View reviewed changes

absidue previously approved these changes Oct 5, 2022

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 5, 2022

Change wording in features

c4046f3

efb4f5ff-1298-471a-8973-3d47447115dc dismissed stale reviews from absidue and PikachuEXE via c4046f3 October 5, 2022 12:26

efb4f5ff-1298-471a-8973-3d47447115dc added 5 commits October 5, 2022 17:49

correction on screenshot feature

62717a1

condense show/hide into one

e2344cb

me -> us

ee633fe

correction on tor proxy

e92e67f

family

ebddd85

ChunkyProgrammer reviewed Oct 7, 2022

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc added 2 commits October 7, 2022 14:08

update proxy feature

cb5e9bf

clarify extension builds

8f28665

PikachuEXE reviewed Oct 8, 2022

View reviewed changes

revert previous commit and add statement

e9eec5f

efb4f5ff-1298-471a-8973-3d47447115dc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: WIP labels Oct 8, 2022

efb4f5ff-1298-471a-8973-3d47447115dc requested review from PikachuEXE, absidue and ChunkyProgrammer October 8, 2022 10:59

absidue approved these changes Oct 8, 2022

View reviewed changes

ChunkyProgrammer approved these changes Oct 8, 2022

View reviewed changes

PikachuEXE approved these changes Oct 9, 2022

View reviewed changes

PrestonN merged commit 2154255 into FreeTubeApp:development Oct 9, 2022

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 9, 2022

efb4f5ff-1298-471a-8973-3d47447115dc deleted the marketing branch October 9, 2022 01:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Advertise FT better in README #2677

Advertise FT better in README #2677

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 4, 2022 •

edited

Loading

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 5, 2022

Uh oh!

PikachuEXE commented Oct 5, 2022

Uh oh!

ChunkyProgrammer commented Oct 5, 2022 •

edited

Loading

Uh oh!

ChunkyProgrammer Oct 7, 2022

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc Oct 7, 2022

Uh oh!

ChunkyProgrammer Oct 7, 2022

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc Oct 7, 2022

Uh oh!

PikachuEXE Oct 8, 2022

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc Oct 8, 2022

Uh oh!

PikachuEXE Oct 9, 2022

Uh oh!

Uh oh!

Advertise FT better in README #2677

Advertise FT better in README #2677

Uh oh!

Conversation

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Advertise FT better in README

Pull Request Type

Description

Screenshots

Additional context

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 5, 2022

Uh oh!

PikachuEXE commented Oct 5, 2022

Uh oh!

ChunkyProgrammer commented Oct 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChunkyProgrammer Oct 7, 2022

Choose a reason for hiding this comment

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc Oct 7, 2022

Choose a reason for hiding this comment

Uh oh!

ChunkyProgrammer Oct 7, 2022

Choose a reason for hiding this comment

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc Oct 7, 2022

Choose a reason for hiding this comment

Uh oh!

PikachuEXE Oct 8, 2022

Choose a reason for hiding this comment

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc Oct 8, 2022

Choose a reason for hiding this comment

Uh oh!

PikachuEXE Oct 9, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 4, 2022 •

edited

Loading

ChunkyProgrammer commented Oct 5, 2022 •

edited

Loading