FreeTubeApp · PrestonN · Sep 23, 2022 · Sep 22, 2022 · Sep 22, 2022
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -32,12 +32,12 @@ module.exports = {
   plugins: ['vue'],
 
   rules: {
-    'space-before-function-paren': 0,
+    'space-before-function-paren': 'off',
     'comma-dangle': ['error', 'never'],
     'vue/no-v-html': 'off',
-    'no-console': 0,
-    'no-unused-vars': 1,
-    'no-undef': 1,
-    'vue/no-template-key': 1
+    'no-console': ['error', { allow: ['warn', 'error'] }],
+    'no-unused-vars': 'warn',
+    'no-undef': 'warn',
+    'vue/no-template-key': 'warn'
   }
 }
diff --git a/src/main/index.js b/src/main/index.js
@@ -9,7 +9,6 @@ import { IpcChannels, DBActions, SyncEvents } from '../constants'
 import baseHandlers from '../datastores/handlers/base'
 
 if (process.argv.includes('--version')) {
-  console.log(`v${app.getVersion()}`)
   app.exit()
 } else {
   runApp()
@@ -172,7 +171,7 @@ function runApp() {
       require('vue-devtools').install()
       /* eslint-enable */
     } catch (err) {
-      console.log(err)
+      console.error(err)
     }
   }
 
@@ -195,7 +194,7 @@ function runApp() {
           return nativeTheme.shouldUseDarkColors ? '#212121' : '#f1f1f1'
       }
     }).catch((error) => {
-      console.log(error)
+      console.error(error)
       // Default to nativeTheme settings if nothing is found.
       return nativeTheme.shouldUseDarkColors ? '#212121' : '#f1f1f1'
     })
@@ -258,7 +257,6 @@ function runApp() {
 
     const boundsDoc = await baseHandlers.settings._findBounds()
     if (typeof boundsDoc?.value === 'object') {
-      console.log({ boundsDoc })
       const { maximized, fullScreen, ...bounds } = boundsDoc.value
       const allDisplaysSummaryWidth = screen
         .getAllDisplays()
@@ -348,8 +346,6 @@ function runApp() {
         // Which raises "Object has been destroyed" error
         mainWindow = allWindows[0]
       }
-
-      console.log('closed')
     })
   }
 
@@ -401,7 +397,6 @@ function runApp() {
   })
 
   ipcMain.on(IpcChannels.ENABLE_PROXY, (_, url) => {
-    console.log(url)
     session.defaultSession.setProxy({
       proxyRules: url
     })

diff --git a/src/renderer/App.js b/src/renderer/App.js
@@ -159,7 +159,6 @@ export default Vue.extend({
         this.grabAllPlaylists()
 
         if (process.env.IS_ELECTRON) {
-          console.log('User is using Electron')
           ipcRenderer = require('electron').ipcRenderer
           this.setupListenersToSyncWindows()
           this.activateKeyboardShortcuts()
@@ -194,11 +193,8 @@ export default Vue.extend({
     },
 
     updateTheme: function (theme) {
-      console.group('updateTheme')
-      console.log('Theme: ', theme)
       document.body.className = `${theme.baseTheme} main${theme.mainColor} sec${theme.secColor}`
       document.body.dataset.systemTheme = this.systemTheme
-      console.groupEnd()
     },
 
     checkForNewUpdates: function () {

diff --git a/src/renderer/components/data-settings/data-settings.js b/src/renderer/components/data-settings/data-settings.js
@@ -528,8 +528,7 @@ export default Vue.extend({
             }
           })
         }).catch((err) => {
-          console.log(err)
-          console.log('error reading')
+          console.error(err)
           const message = this.$t('Settings.Data Settings.Invalid subscriptions file')
           this.showToast({
             message: `${message}: ${err}`
@@ -946,7 +945,7 @@ export default Vue.extend({
       this.handleFreetubeImportFile(dbLocation)
       fs.unlink(dbLocation, (err) => {
         if (err) {
-          console.log(err)
+          console.error(err)
         }
       })
     },
@@ -1285,7 +1284,7 @@ export default Vue.extend({
         this.invidiousAPICall(subscriptionsPayload).then((response) => {
           resolve(response)
         }).catch((err) => {
-          console.log(err)
+          console.error(err)
           const errorMessage = this.$t('Invidious API Error (Click to copy)')
           this.showToast({
             message: `${errorMessage}: ${err.responseJSON.error}`,
@@ -1312,7 +1311,7 @@ export default Vue.extend({
         ytch.getChannelInfo({ channelId: channelId }).then(async (response) => {
           resolve(response)
         }).catch((err) => {
-          console.log(err)
+          console.error(err)
           const errorMessage = this.$t('Local API Error (Click to copy)')
           this.showToast({
             message: `${errorMessage}: ${err}`,

diff --git a/src/renderer/components/ft-list-dropdown/ft-list-dropdown.js b/src/renderer/components/ft-list-dropdown/ft-list-dropdown.js
@@ -31,12 +31,5 @@ export default Vue.extend({
     listType: function () {
       return this.$store.getters.getListType
     }
-  },
-  mounted: function () {
-  },
-  methods: {
-    goToChannel: function () {
-      console.log('TODO: ft-list-channel method goToChannel')
-    }
   }
 })
diff --git a/src/renderer/components/ft-list-video/ft-list-video.js b/src/renderer/components/ft-list-video/ft-list-video.js
@@ -291,9 +291,6 @@ export default Vue.extend({
     },
 
     handleOptionsClick: function (option) {
-      console.log('Handling share')
-      console.log(option)
-
       switch (option) {
         case 'history':
           if (this.watched) {

diff --git a/src/renderer/components/ft-profile-edit/ft-profile-edit.js b/src/renderer/components/ft-profile-edit/ft-profile-edit.js
@@ -111,8 +111,6 @@ export default Vue.extend({
         profile._id = this.profileId
       }
 
-      console.log(profile)
-
       if (this.isNew) {
         this.createProfile(profile)
         this.showToast({

diff --git a/src/renderer/components/ft-video-player/ft-video-player.js b/src/renderer/components/ft-video-player/ft-video-player.js
@@ -157,7 +157,7 @@ export default Vue.extend({
       try {
         return JSON.parse(this.$store.getters.getDefaultCaptionSettings)
       } catch (e) {
-        console.log(e)
+        console.error(e)
         return {}
       }
     },
@@ -343,7 +343,6 @@ export default Vue.extend({
   },
   methods: {
     initializePlayer: async function () {
-      console.log(this.adaptiveFormats)
       const videoPlayer = document.getElementById(this.id)
       if (videoPlayer !== null) {
         if (!this.useDash) {
@@ -1034,7 +1033,7 @@ export default Vue.extend({
 
     enableDashFormat: function () {
       if (this.dashSrc === null) {
-        console.log('No dash format available.')
+        console.warn('No dash format available.')
         return
       }
 
@@ -1047,7 +1046,7 @@ export default Vue.extend({
 
     enableLegacyFormat: function () {
       if (this.sourceList.length === 0) {
-        console.log('No sources available')
+        console.error('No sources available')
         return
       }
 
@@ -1112,7 +1111,6 @@ export default Vue.extend({
       const frameTime = 1 / fps
       const dist = frameTime * step
       this.player.currentTime(this.player.currentTime() + dist)
-      console.log(fps)
     },
 
     changeVolume: function (volume) {
@@ -1427,7 +1425,6 @@ export default Vue.extend({
           VjsButton.call(this, player, options)
         },
         handleClick: (event) => {
-          console.log(event)
           const selectedQuality = event.target.innerText
           const bitrate = selectedQuality === 'auto' ? 'auto' : parseInt(event.target.attributes.bitrate.value)
           this.setDashQualityLevel(bitrate)
@@ -1685,7 +1682,6 @@ export default Vue.extend({
       clearTimeout(this.touchPauseTimeout)
     },
     toggleShowStatsModal: function() {
-      console.log(this.format)
       if (this.format !== 'dash') {
         this.showToast({
           message: this.$t('Video.Stats.Video statistics are not available for legacy videos')

diff --git a/src/renderer/components/general-settings/general-settings.js b/src/renderer/components/general-settings/general-settings.js
@@ -205,7 +205,6 @@ export default Vue.extend({
 
     handlePreferredApiBackend: function (backend) {
       this.updateBackendPreference(backend)
-      console.log(backend)
 
       if (backend === 'local') {
         this.updateForceLocalBackendForLegacy(false)

diff --git a/src/renderer/components/playlist-info/playlist-info.js b/src/renderer/components/playlist-info/playlist-info.js
@@ -82,7 +82,6 @@ export default Vue.extend({
     }
   },
   mounted: function () {
-    console.log(this.data)
     this.id = this.data.id
     this.firstVideoId = this.data.firstVideoId
     this.title = this.data.title

diff --git a/src/renderer/components/top-nav/top-nav.js b/src/renderer/components/top-nav/top-nav.js
@@ -252,9 +252,9 @@ export default Vue.extend({
       this.invidiousAPICall(searchPayload).then((results) => {
         this.searchSuggestionsDataList = results.suggestions
       }).catch((err) => {
-        console.log(err)
+        console.error(err)
         if (this.backendFallback) {
-          console.log(
+          console.error(
             'Error gettings search suggestions.  Falling back to Local API'
           )
           this.getSearchSuggestionsLocal(query)

diff --git a/src/renderer/components/watch-video-comments/watch-video-comments.js b/src/renderer/components/watch-video-comments/watch-video-comments.js
@@ -182,7 +182,7 @@ export default Vue.extend({
       ytcm.getComments(payload).then((response) => {
         this.parseLocalCommentData(response, null)
       }).catch((err) => {
-        console.log(err)
+        console.error(err)
         const errorMessage = this.$t('Local API Error (Click to copy)')
         this.showToast({
           message: `${errorMessage}: ${err}`,
@@ -217,7 +217,7 @@ export default Vue.extend({
       ytcm.getCommentReplies(payload).then((response) => {
         this.parseLocalCommentData(response, payload.index)
       }).catch((err) => {
-        console.log(err)
+        console.error(err)
         const errorMessage = this.$t('Local API Error (Click to copy)')
         this.showToast({
           message: `${errorMessage}: ${err}`,
@@ -332,8 +332,7 @@ export default Vue.extend({
         this.isLoading = false
         this.showComments = true
       }).catch((xhr) => {
-        console.log('found an error')
-        console.log(xhr)
+        console.error(xhr)
         const errorMessage = this.$t('Invidious API Error (Click to copy)')
         this.showToast({
           message: `${errorMessage}: ${xhr.responseText}`,
@@ -389,8 +388,7 @@ export default Vue.extend({
         this.commentData[index].showReplies = true
         this.isLoading = false
       }).catch((xhr) => {
-        console.log('found an error')
-        console.log(xhr)
+        console.error(xhr)
         const errorMessage = this.$t('Invidious API Error (Click to copy)')
         this.showToast({
           message: `${errorMessage}: ${xhr.responseText}`,

diff --git a/src/renderer/components/watch-video-info/watch-video-info.js b/src/renderer/components/watch-video-info/watch-video-info.js
@@ -2,7 +2,6 @@ import Vue from 'vue'
 import { mapActions } from 'vuex'
 import FtCard from '../ft-card/ft-card.vue'
 import FtButton from '../ft-button/ft-button.vue'
-import FtListDropdown from '../ft-list-dropdown/ft-list-dropdown.vue'
 import FtFlexBox from '../ft-flex-box/ft-flex-box.vue'
 import FtIconButton from '../ft-icon-button/ft-icon-button.vue'
 import FtShareButton from '../ft-share-button/ft-share-button.vue'
@@ -14,7 +13,6 @@ export default Vue.extend({
   components: {
     'ft-card': FtCard,
     'ft-button': FtButton,
-    'ft-list-dropdown': FtListDropdown,
     'ft-flex-box': FtFlexBox,
     'ft-icon-button': FtIconButton,
     'ft-share-button': FtShareButton

diff --git a/src/renderer/components/watch-video-live-chat/watch-video-live-chat.js b/src/renderer/components/watch-video-live-chat/watch-video-live-chat.js
@@ -85,7 +85,6 @@ export default Vue.extend({
     } else {
       switch (this.backendPreference) {
         case 'local':
-          console.log('Getting Chat')
           this.getLiveChatLocal()
           break
         case 'invidious':
@@ -115,13 +114,12 @@ export default Vue.extend({
       this.isLoading = false
 
       this.liveChat.on('start', (liveId) => {
-        console.log('Live chat is enabled')
         this.isLoading = false
       })
 
       this.liveChat.on('end', (reason) => {
-        console.log('Live chat has ended')
-        console.log(reason)
+        console.error('Live chat has ended')
+        console.error(reason)
         this.hasError = true
         this.showEnableChat = false
         this.errorMessage = this.$t('Video["Chat is disabled or the Live Stream has ended."]')
@@ -141,8 +139,6 @@ export default Vue.extend({
     },
 
     parseLiveChatComment: function (comment) {
-      console.log(comment)
-
       if (this.hasEnded) {
         return
       }
@@ -171,13 +167,12 @@ export default Vue.extend({
       const liveChatMessage = $('.liveChatMessage')
 
       if (typeof (liveChatComments.get(0)) === 'undefined' && typeof (liveChatMessage.get(0)) === 'undefined') {
-        console.log("Can't find chat object.  Stopping chat connection")
+        console.error("Can't find chat object.  Stopping chat connection")
         this.liveChat.stop()
         return
       }
 
       this.comments.push(comment)
-      console.log(this.comments.length)
 
       if (typeof (comment.superchat) !== 'undefined') {
         this.getRandomColorClass().then((data) => {
@@ -211,7 +206,6 @@ export default Vue.extend({
       }
 
       if (this.comments.length > 150 && this.stayAtBottom) {
-        console.log('user is not at bottom')
         this.comments = this.comments.splice(this.comments.length - 150, this.comments.length)
       }
     },

diff --git a/src/renderer/components/watch-video-playlist/watch-video-playlist.js b/src/renderer/components/watch-video-playlist/watch-video-playlist.js
@@ -278,9 +278,6 @@ export default Vue.extend({
       this.isLoading = true
 
       this.ytGetPlaylistInfo(this.playlistId).then((result) => {
-        console.log('done')
-        console.log(result)
-
         this.playlistTitle = result.title
         this.playlistItems = result.items
         this.videoCount = result.estimatedItemCount
@@ -307,7 +304,7 @@ export default Vue.extend({
 
         this.isLoading = false
       }).catch((err) => {
-        console.log(err)
+        console.error(err)
         const errorMessage = this.$t('Local API Error (Click to copy)')
         this.showToast({
           message: `${errorMessage}: ${err}`,
@@ -336,9 +333,6 @@ export default Vue.extend({
       }
 
       this.invidiousGetPlaylistInfo(payload).then((result) => {
-        console.log('done')
-        console.log(result)
-
         this.playlistTitle = result.title
         this.videoCount = result.videoCount
         this.channelName = result.author
@@ -348,7 +342,7 @@ export default Vue.extend({
 
         this.isLoading = false
       }).catch((err) => {
-        console.log(err)
+        console.error(err)
         const errorMessage = this.$t('Invidious API Error (Click to copy)')
         this.showToast({
           message: `${errorMessage}: ${err}`,