Fix for banner and too far scrolling #2398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
PikachuEXE
approved these changes
Jul 13, 2022
PikachuEXE
requested changes
Jul 13, 2022
PikachuEXE
requested review from
absidue,
ChunkyProgrammer and
efb4f5ff-1298-471a-8973-3d47447115dc
PikachuEXE
approved these changes
Jul 14, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jul 16, 2022
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Jul 20, 2022
1 task
PrestonN
pushed a commit
that referenced
this pull request
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for banner and too far scrolling
Pull Request Type
Please select what type of pull request this is:
Related issue
From dev channel
Description
The last fix for the overflowing banner introduced a bug that lets you scroll past the video section on any page.
This is now fixed by a small restructuring of how the app layout works and how it is styled
Testing (for code that is not small enough to be easily understandable)
Tested with and without banner
Desktop (please complete the following information):