Skip to content

Fix right clicking on links being treated as link clicks #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

absidue
Copy link
Member

@absidue absidue commented Jun 23, 2022


Fix right clicking on links being treated as link clicks (RC branch)

Pull Request Type

  • Bugfix

Related issue
closes #2343

Description
This PR fixes right clicking on links opening them instead of the context menu showing up.

Testing (for code that is not small enough to be easily understandable)
Right click on a bunch of links, with this PR only the context menu should show up.

Desktop (please complete the following information):

  • OS: Windows
  • OS Version: 10
  • FreeTube version: dd879b6

@absidue absidue added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 23, 2022
@PrestonN PrestonN enabled auto-merge (squash) June 23, 2022 20:08
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in #2355 (review)

@PikachuEXE
Copy link
Collaborator

@PrestonN PrestonN merged commit 2bee1f1 into FreeTubeApp:v0.17.0-RC Jun 30, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 30, 2022
@absidue absidue deleted the fix-right-clicking-links-rc branch June 30, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants