Skip to content

fix: search suggestion get stuck [rc] #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2022
Merged

fix: search suggestion get stuck [rc] #2354

merged 1 commit into from
Jul 1, 2022

Conversation

hockerschwan
Copy link
Contributor

Please select what type of pull request this is:

  • Bugfix

Related issue
#2309 (comment)

Description

search something -> see search suggestions -> navigate through the suggestions with the arrow keys on your key board -> get stuck

Screenshots (if appropriate)

1.mp4

Desktop (please complete the following information):

  • OS: Windows 10 21H1
  • FreeTube version: 0.17rc

@PrestonN PrestonN enabled auto-merge (squash) June 22, 2022 17:48
Copy link

@Quix0r Quix0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this.visibleDataList is the proper list, then this looks fine.

@ChunkyProgrammer ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 23, 2022
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still got stuck in this version though?

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: waiting for review For PRs that are complete, tested, and ready for review PR: changes requested labels Jun 23, 2022
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that i mixed up PRs. This works!

@PrestonN PrestonN merged commit 7a374ac into FreeTubeApp:v0.17.0-RC Jul 1, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants