Skip to content

Clear filter when clicked "Clear input" [0.17RC] #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2022
Merged

Clear filter when clicked "Clear input" [0.17RC] #2350

merged 1 commit into from
Jun 24, 2022

Conversation

hockerschwan
Copy link
Contributor

Pull Request Type

  • Bugfix

Related issue
#2346

Description

  1. Add items to userplaylists and history
  2. Filter to show fewer results
  3. Click "Clear input"
  4. Filter state persists, not showing all items

Screenshots (if appropriate)
Before

1.mp4

After

2.mp4

Desktop (please complete the following information):

  • OS: Windows10 21H1
  • FreeTube version: d1a7bc3

@PrestonN PrestonN enabled auto-merge (squash) June 22, 2022 16:23
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 22, 2022
@hockerschwan hockerschwan mentioned this pull request Jun 22, 2022
Closed
1 task
PikachuEXE
PikachuEXE approved these changes Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@PrestonN PrestonN merged commit 4a5d091 into FreeTubeApp:v0.17.0-RC Jun 24, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hockerschwan @PikachuEXE @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @PrestonN