Skip to content

Fix randomly occurring error when searching #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2022

Conversation

absidue
Copy link
Member

@absidue absidue commented Mar 24, 2022


Fix randomly occurring error when searching

Important note
We may remove your pull request if you do not use this provided PR template correctly.

Pull Request Type
Please select what type of pull request this is:

  • Bugfix
  • Feature Implementation

Related issue
I haven't created an issue for this.

Description
Randomly I have been experiencing issues when searching, I'm not sure what the cause is. Interestingly updating ytsr to the latest release (3.6.0), seems to have fixed the issue for me. This pull request implements that dependency version bump.

Screenshots (if appropriate)

freetube-search-issue-2

Testing (for code that is not small enough to be easily understandable)
Has this pull request been tested?

Yes, I have been running this for a few days without any issues.

Desktop (please complete the following information):

  • OS: Window
  • OS Version: 10
  • FreeTube version: [e.g. 0.8]

Additional context
Add any other context about the problem here.

@PrestonN PrestonN enabled auto-merge (squash) March 24, 2022 22:05
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work like a charm!

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 24, 2022
@PrestonN PrestonN merged commit 48bdd3f into FreeTubeApp:development Mar 26, 2022
@absidue absidue deleted the update-ytsr branch March 26, 2022 07:01
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants