You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched the issue tracker for a bug report that matches the one I want to file, without success.
I have searched the documentation for information that matches the description of the bug I want to file, without success.
Describe the bug
Select "Invidious API" as the preferred API backend.
Navigate to a channel with featured channels.
Click on one of the featured channel icons.
The page remains the same except that the body changes to contain the text: "Could not get channel info".
I started debugging this issue in my fork (original issue: MarmadileManteater#12) because I thought it was something I introduced, but I found the issue was inside of ./src/renderer/views/Channel/Channel.vue, and I was able to replicate the issue on the newest release.
Expected Behavior
Clicking one of the featured channel icons should change the route to the id of that featured channel.
Issue Labels
API issue
FreeTube Version
v0.17.1
Operating System Version
Windows 10 Pro Version 21H2 Installed on 4/3/2022 OS build 19044.1889 Experience Windows Feature Experience Pack 120.2212.4180.0
Installation Method
.exe
Primary API used
Invidious API
Last Known Working FreeTube Version (If Any)
No response
Additional Information
I believe the issue is that the ft-channel-bubble element expects featured channels to contain the key "channelId".
<!-- line 130 of src/renderer/views/Channel/Channel.vue -->
<ft-channel-bubblev-for="(channel, index) inrelatedChannels"
:key="index"
:channel-name="channel.author||channel.channelName"
:channel-id="channel.channelId"
:channel-thumbnail="channel.authorThumbnails[channel.authorThumbnails.length-1].url"
@click="goToChannel(channel.channelId)"
/>
The problem is that the response from the Invidious API only contains a key named "authorId", not "channelId". This could be fixed by mapping the "channelId" field to "authorId" inside of the getChannelInfoInvidious function in ./src/renderer/views/Channel/Channel.js. There already is a map for the related channels, so this could be fixed with one new line of code inside that map.
// line 417 of src/renderer/views/Channel/Channel.jsthis.relatedChannels=response.relatedChannels.map((channel)=>{channel.authorThumbnails[channel.authorThumbnails.length-1].url=channel.authorThumbnails[channel.authorThumbnails.length-1].url.replace('https://yt3.ggpht.com',`${this.currentInvidiousInstance}/ggpht/`)// Mapping authorId to channelIdchannel.channelId=channel.authorId;returnchannel})
Nightly Build
I have encountered this bug in the latest nightly build.
The text was updated successfully, but these errors were encountered:
Added a line to map the field "authorId" to "channelId"
on the featured channels that come from the Invidious API
because the Channel view expects related channels to have
the property "channelId". This is related to FreeTubeApp#2481.
Added a line to map the field "authorId" to "channelId"
on the featured channels that come from the Invidious API
because the Channel view expects related channels to have
the property "channelId". This is related to #2481.
Guidelines
Describe the bug
The page remains the same except that the body changes to contain the text: "Could not get channel info".
I started debugging this issue in my fork (original issue: MarmadileManteater#12) because I thought it was something I introduced, but I found the issue was inside of
./src/renderer/views/Channel/Channel.vue
, and I was able to replicate the issue on the newest release.Expected Behavior
Clicking one of the featured channel icons should change the route to the id of that featured channel.
Issue Labels
API issue
FreeTube Version
v0.17.1
Operating System Version
Windows 10 Pro Version 21H2 Installed on 4/3/2022 OS build 19044.1889 Experience Windows Feature Experience Pack 120.2212.4180.0
Installation Method
.exe
Primary API used
Invidious API
Last Known Working FreeTube Version (If Any)
No response
Additional Information
I believe the issue is that the
ft-channel-bubble
element expects featured channels to contain the key "channelId".The problem is that the response from the Invidious API only contains a key named "authorId", not "channelId". This could be fixed by mapping the "channelId" field to "authorId" inside of the
getChannelInfoInvidious
function in./src/renderer/views/Channel/Channel.js
. There already is a map for the related channels, so this could be fixed with one new line of code inside that map.Nightly Build
The text was updated successfully, but these errors were encountered: