only remove entries if they are there #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a problem on fedora. If this check is not done, removing a kernel will fail and the rpmdb will become corrupt, showing multiple entries. (use: "rpm -e --allmatches" to remove them) I bet this hack is imperfect, but it sure is a step in the right direction.
hboetes
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
hboetes
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
hboetes
temporarily deployed
to
Build, sign, release binaries
GitHub Actions
Inactive
|
(you can ignore the CI checks. I need to do some cleanup) Thanks! |
|
No worries, I'm used to it. |
Foxboron
approved these changes
Apr 14, 2024
|
Any idea when we will have a new release with this one? |
|
That would be nice indeed, on every machine I'm rolling out sbctl I also have to apply this patch or notice kernel uninstalls failing. |
|
Yes, I've been down with a fever+busy and as a result been behind on my other FOSS work the past week. |
|
Hey @Foxboron no worries, health always comes first! Not sure what's your internal process to cut out a release but if there's anything I can help with let me know! |
|
Just got the update in Fedora with the fix though the COPR repo I used. Thanks @Foxboron for merging this and cutting the new release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem on fedora.
If this check is not done, removing a kernel will fail and the rpmdb will become corrupt, showing multiple entries. (use: "rpm -e --allmatches" to remove them)
I bet this hack is imperfect, but it sure is a step in the right direction.