Correctly enable sideEffects for css files #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitten
reviewed
May 17, 2018
There was a problem hiding this comment.
Oh I didn’t know about this more specific syntax cc @ryan-roemer
kitten
approved these changes
May 17, 2018
|
Any news on this? :) |
|
Hiya, sorry I've been leaving this around for a while without a reply. We are indeed allowed to set sideEffects to true as I suspected as we're using it as intended. Yes, you can regard this injection as a side effect, but in this context what is meant are side effects during evaluation which would stop bundles from tree shaking correctly. Thanks for the PR but I'll close it since it doesn't seem to be a change we need to make :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-live sets currently
sideEffects: falseinpackage.jsonwhich is correct for all the js files, but not for the css file(s). css obviously always has sideEffects and for now there is no better solution than specifying this in every package. (see ref)Ref: webpack-contrib/mini-css-extract-plugin#102