Skip to content

Adapt generated eslint config to support ctx.session! #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Nov 3, 2022

Issue

When following the second tutorial, we get an ESLint warning with the IDE on statements such as ctx.session!. This PR removes this warning to not confuse people following the tutorial.

Solution and steps

  • Disable config rule @typescript-eslint/no-non-null-assertion

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain mentioned this pull request Nov 3, 2022
6 tasks
@LoicPoullain LoicPoullain merged commit ef2fd9d into v3-1-0 Nov 3, 2022
@LoicPoullain LoicPoullain deleted the fix-eslint-rule branch November 3, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant