Skip to content

Append extension to name if file basename is not unique #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 8, 2021

Conversation

lcdsmao
Copy link
Member

@lcdsmao lcdsmao commented Feb 7, 2021

What does this change?

Resolve #59

What is the value of this and can you measure success?

Pass CI

@codecov
Copy link

codecov bot commented Feb 7, 2021

Codecov Report

Merging #78 (f1adaf0) into main (57d1f6a) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   98.15%   98.22%   +0.06%     
==========================================
  Files          16       16              
  Lines         489      506      +17     
==========================================
+ Hits          480      497      +17     
  Misses          9        9              
Impacted Files Coverage Δ
lib/src/generators/assets_generator.dart 100.00% <100.00%> (ø)
lib/src/settings/asset_type.dart 96.87% <100.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d1f6a...67b211e. Read the comment docs.

@lcdsmao lcdsmao requested a review from wasabeef February 7, 2021 07:03
@lcdsmao lcdsmao force-pushed the handle-duplicate-name branch from f6fd937 to 67b211e Compare February 7, 2021 07:17
Copy link
Member

@wasabeef wasabeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

@lcdsmao lcdsmao merged commit 33e0a6c into main Feb 8, 2021
@lcdsmao lcdsmao deleted the handle-duplicate-name branch February 8, 2021 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Handling duplicate file names
2 participants