-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing parameters in Lottie integration from lottie 3.0.0 #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 21 21
Lines 819 819
=======================================
Hits 799 799
Misses 20 20 ☔ View full report in Codecov by Sentry. |
AlexV525
approved these changes
Feb 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
8 tasks
AlexV525
pushed a commit
that referenced
this pull request
Feb 27, 2025
## What does this change? Due to #656, Lottie supports Telegram Stickers (.tgs) and `.tgs` files can be loaded by providing a special decoder. This MR will support `.tgs`. Proof of work: https://github.com/user-attachments/assets/19ab6acb-793a-4f9c-b6b3-4c3524511d4d
Merged
AlexV525
added a commit
that referenced
this pull request
Mar 2, 2025
## 5.10.0 **Feature** - [#659](#659) Add support Telegram Sticker `.tgs` in Lottie Integration. by [@dungngminh](https://github.com/dungngminh) **Bug fix** - [#653](#653) Constraints `dart_style` to `>=2.3.7`. by [@AlexV525](https://github.com/AlexV525) - [#656](#656) Add missing parameters in Lottie integration from lottie 3.0.0. by [@dungngminh](https://github.com/dungngminh) - [#658](#658) Update required dart version. by [@koji-1009](https://github.com/koji-1009)
bluesky950520
added a commit
to bluesky950520/flutter_gen-edit
that referenced
this pull request
Mar 11, 2025
## 5.10.0 **Feature** - [#659](FlutterGen/flutter_gen#659) Add support Telegram Sticker `.tgs` in Lottie Integration. by [@dungngminh](https://github.com/dungngminh) **Bug fix** - [#653](FlutterGen/flutter_gen#653) Constraints `dart_style` to `>=2.3.7`. by [@AlexV525](https://github.com/AlexV525) - [#656](FlutterGen/flutter_gen#656) Add missing parameters in Lottie integration from lottie 3.0.0. by [@dungngminh](https://github.com/dungngminh) - [#658](FlutterGen/flutter_gen#658) Update required dart version. by [@koji-1009](https://github.com/koji-1009)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Type of change
Please delete options that are not relevant.
Checklist:
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
melos run test
)melos run format
to automatically apply formatting)