Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parameters in Lottie integration from lottie 3.0.0 #656

Merged
merged 4 commits into from
Feb 9, 2025

Conversation

dungngminh
Copy link
Contributor

@dungngminh dungngminh commented Feb 8, 2025

What does this change?

  • This MR will add missing parameters in Lottie Integration from lottie's release 3.0.0
  • chore: I also updated actual test data after running test

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (89e32fe) to head (90b2431).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #656   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files          21       21           
  Lines         819      819           
=======================================
  Hits          799      799           
  Misses         20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dungngminh dungngminh changed the title Add missing parameters in Lottie Integrate from lottie 3.0.0 Add missing parameters in Lottie integration from lottie 3.0.0 Feb 8, 2025
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AlexV525 AlexV525 merged commit 209aced into FlutterGen:main Feb 9, 2025
5 checks passed
AlexV525 pushed a commit that referenced this pull request Feb 27, 2025
## What does this change?

Due to #656, Lottie supports Telegram Stickers (.tgs) and `.tgs` files can be loaded by providing a special decoder. This MR will support `.tgs`.

Proof of work:
https://github.com/user-attachments/assets/19ab6acb-793a-4f9c-b6b3-4c3524511d4d
@AlexV525 AlexV525 mentioned this pull request Mar 2, 2025
AlexV525 added a commit that referenced this pull request Mar 2, 2025
## 5.10.0

**Feature**
- [#659](#659) Add support
Telegram Sticker `.tgs` in Lottie Integration. by
[@dungngminh](https://github.com/dungngminh)

**Bug fix**
- [#653](#653) Constraints
`dart_style` to `>=2.3.7`. by [@AlexV525](https://github.com/AlexV525)
- [#656](#656) Add missing
parameters in Lottie integration from lottie 3.0.0. by
[@dungngminh](https://github.com/dungngminh)
- [#658](#658) Update
required dart version. by [@koji-1009](https://github.com/koji-1009)
@AlexV525 AlexV525 added this to the 5.10.0 milestone Mar 2, 2025
bluesky950520 added a commit to bluesky950520/flutter_gen-edit that referenced this pull request Mar 11, 2025
## 5.10.0

**Feature**
- [#659](FlutterGen/flutter_gen#659) Add support
Telegram Sticker `.tgs` in Lottie Integration. by
[@dungngminh](https://github.com/dungngminh)

**Bug fix**
- [#653](FlutterGen/flutter_gen#653) Constraints
`dart_style` to `>=2.3.7`. by [@AlexV525](https://github.com/AlexV525)
- [#656](FlutterGen/flutter_gen#656) Add missing
parameters in Lottie integration from lottie 3.0.0. by
[@dungngminh](https://github.com/dungngminh)
- [#658](FlutterGen/flutter_gen#658) Update
required dart version. by [@koji-1009](https://github.com/koji-1009)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants