Skip to content

fix: provide theme to SvgAssetLoader instead of SvgPicture #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2024
Merged

fix: provide theme to SvgAssetLoader instead of SvgPicture #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d5dbec
fix: provide theme to SvgAssetLoader instead of SvgPicture
Kirpal Jun 20, 2024
b427a82
revert formatting changes
Kirpal Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions examples/example/lib/gen/assets.gen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ class SvgGenImage {
? AssetBytesLoader(_assetName,
assetBundle: bundle, packageName: package)
: SvgAssetLoader(_assetName,
assetBundle: bundle, packageName: package),
assetBundle: bundle, packageName: package, theme: theme),
key: key,
matchTextDirection: matchTextDirection,
width: width,
Expand All @@ -329,7 +329,6 @@ class SvgGenImage {
placeholderBuilder: placeholderBuilder,
semanticsLabel: semanticsLabel,
excludeFromSemantics: excludeFromSemantics,
theme: theme,
colorFilter: colorFilter ??
(color == null ? null : ColorFilter.mode(color, colorBlendMode)),
clipBehavior: clipBehavior,
Expand Down
3 changes: 1 addition & 2 deletions examples/example_resources/lib/gen/assets.gen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ class SvgGenImage {
? AssetBytesLoader(_assetName,
assetBundle: bundle, packageName: package)
: SvgAssetLoader(_assetName,
assetBundle: bundle, packageName: package),
assetBundle: bundle, packageName: package, theme: theme),
key: key,
matchTextDirection: matchTextDirection,
width: width,
Expand All @@ -197,7 +197,6 @@ class SvgGenImage {
placeholderBuilder: placeholderBuilder,
semanticsLabel: semanticsLabel,
excludeFromSemantics: excludeFromSemantics,
theme: theme,
colorFilter: colorFilter ??
(color == null ? null : ColorFilter.mode(color, colorBlendMode)),
clipBehavior: clipBehavior,
Expand Down
3 changes: 1 addition & 2 deletions packages/core/lib/generators/integrations/svg_integration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ ${isPackage ? "\n static const String package = '$packageName';" : ''}
return SvgPicture(
_isVecFormat ?
AssetBytesLoader(_assetName, assetBundle: bundle, packageName: package) :
SvgAssetLoader(_assetName, assetBundle: bundle, packageName: package),
SvgAssetLoader(_assetName, assetBundle: bundle, packageName: package, theme: theme),
key: key,
matchTextDirection: matchTextDirection,
width: width,
Expand All @@ -73,7 +73,6 @@ ${isPackage ? "\n static const String package = '$packageName';" : ''}
placeholderBuilder: placeholderBuilder,
semanticsLabel: semanticsLabel,
excludeFromSemantics: excludeFromSemantics,
theme: theme,
colorFilter: colorFilter ?? (color == null ? null : ColorFilter.mode(color, colorBlendMode)),
clipBehavior: clipBehavior,
cacheColorFilter: cacheColorFilter,
Expand Down
3 changes: 1 addition & 2 deletions packages/core/test_resources/actual_data/assets.gen.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions packages/core/test_resources/actual_data/assets_directory_path.gen.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions packages/core/test_resources/actual_data/assets_package_parameter.gen.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions packages/core/test_resources/actual_data/assets_parse_metadata.gen.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions packages/core/test_resources/actual_data/assets_svg_integrations.gen.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions packages/runner/example/lib/gen/assets.gen.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading