Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'useArtboardSize' argument in rive integration #487

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

devilbuddy
Copy link
Contributor

@devilbuddy devilbuddy commented Mar 22, 2024

What does this change?

Add support for 'useArtboardSize' argument in rive integration

Fixes #486 🎯

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (2db938f) to head (b26b2d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files          22       22           
  Lines         756      756           
=======================================
  Hits          735      735           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The branch requires to be updated.

@AlexV525 AlexV525 merged commit fde34d5 into FlutterGen:main Mar 23, 2024
5 checks passed
@wasabeef wasabeef added this to the 5.5.0+1 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Support for useArtboardSize in RiveAnimation.asset
3 participants