Fixes flutter_svg latest version requiring a non null clipBehavior field.

[jetpeter]

What does this change?

Fixes flutter_svg latest version requiring a non null clipBehavior field.

Fixes #368

Type of change

Please delete options that are not relevant.

• [X ] Bug fix (non-breaking change which fixes an issue)

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• [X ] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests (melos run unit:test)
  • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
• Appropriate docs were updated (if necessary)

[jetpeter]

Tests are broken for this because they expect updated files in the tests_resources/actual_data file. Is there a command that generated all of those test files, with all the different parameters? I will update this with the correct test data, but I assume it does not need to be manually done.

[wasabeef]

@jetpeter
Thank you, I'll check this PR.

[jfacoustic]

I tested your commit, but it doesn't seem to be generating the code with the nonNullable clip behavior. Any ideas what might be going on?

Added it to my pubspec like so:

  flutter_gen_runner:
    git:
      url: https://github.com/jetpeter/flutter_gen
      path: packages/runner
      ref: 785161759cf07319c59d5ecc9de4ef66662bcd95

[noga-dev]

I tested your commit, but it doesn't seem to be generating the code with the nonNullable clip behavior. Any ideas what might be going on?

Added it to my pubspec like so:

  flutter_gen_runner:
    git:
      url: https://github.com/jetpeter/flutter_gen
      path: packages/runner
      ref: 785161759cf07319c59d5ecc9de4ef66662bcd95

Can confirm. I basically had to delete the line clipBehavior: clipBehavior, from SvgGenImage.svg in assets.gen.dart

[jetpeter]

I tested your commit, but it doesn't seem to be generating the code with the nonNullable clip behavior. Any ideas what might be going on?

Added it to my pubspec like so:

  flutter_gen_runner:
    git:
      url: https://github.com/jetpeter/flutter_gen
      path: packages/runner
      ref: 785161759cf07319c59d5ecc9de4ef66662bcd95

Change was not made to flutter_gen_runner. It was made to flutter_gen_core. To get the fix you need to add

dependency_overrides:
  flutter_gen_core:
    git:
      url: https://github.com/jetpeter/flutter_gen
      path: packages/core
      ref: 785161759cf07319c59d5ecc9de4ef66662bcd95

below your dev_dependencies: block.
You don't actually need to override flutter_gen_runner since there are not changes to it.

[jetpeter]

I updated the test files to reflect the changes in flutter_svg. This should be good to go now.

[noga-dev]

I tested your commit, but it doesn't seem to be generating the code with the nonNullable clip behavior. Any ideas what might be going on?
Added it to my pubspec like so:

  flutter_gen_runner:
    git:
      url: https://github.com/jetpeter/flutter_gen
      path: packages/runner
      ref: 785161759cf07319c59d5ecc9de4ef66662bcd95

Change was not made to flutter_gen_runner. It was made to flutter_gen_core. To get the fix you need to add

dependency_overrides:
  flutter_gen_core:
    git:
      url: https://github.com/jetpeter/flutter_gen
      path: packages/core
      ref: 785161759cf07319c59d5ecc9de4ef66662bcd95

below your dev_dependencies: block. You don't actually need to override flutter_gen_runner since there are not changes to it.

Oops, didn't notice the changes we're in the core package. Thanks. LGTM.

[wasabeef]

@jetpeter @szelemeh @jetpeter @noga-dev

Thank you, I will release a new version today.

[codecov]

Codecov Report

Merging #369 (9522955) into main (ef79ae8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          20       20           
  Lines         693      693           
=======================================
  Hits          681      681           
  Misses         12       12           

Impacted Files	Coverage Δ
...e/lib/generators/integrations/svg_integration.dart	100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[wasabeef]

@jetpeter @jfacoustic @noga-dev @szelemeh

I just released v5.3.0. Sorry I kept you waiting.