Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flutter_svg params #34

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Fix flutter_svg params #34

merged 2 commits into from
Sep 9, 2020

Conversation

wasabeef
Copy link
Member

@wasabeef wasabeef commented Sep 9, 2020

What does this change?

  • Fix insufficient params of flutter_svg.

What is the value of this and can you measure success?

  • Pass CI.

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #34 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files          15       15           
  Lines         363      363           
=======================================
  Hits          347      347           
  Misses         16       16           
Impacted Files Coverage Δ
...b/src/generators/integrations/svg_integration.dart 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf5b26...1532412. Read the comment docs.

@wasabeef wasabeef added this to the 1.0.3 milestone Sep 9, 2020
@wasabeef wasabeef merged commit 8b6d49a into main Sep 9, 2020
@wasabeef wasabeef deleted the fix-svg-params branch September 9, 2020 14:49
@wasabeef wasabeef mentioned this pull request Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant