[MIRROR] Ambience Buzz Handling Changes + Ambience buzz requires enviorment power #4183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orment power [MDB IGNORE] (#3440) * Ambience Buzz Handling Changes + Ambience buzz requires enviorment power * conflict --------- Co-authored-by: The Sharkening <[email protected]> Co-authored-by: Fluffles <[email protected]>
Steals-The-PRs
added
Mirroring conflict
AnywayFarus
added a commit
that referenced
this pull request
Jul 3, 2024
Iajret
pushed a commit
that referenced
this pull request
Aug 8, 2024
* 'Cybersun Training Sim' DM arena * deco update * lol oops * make it prettier * One Lattice * floor prettier * last thing probably * embarrassing dont open * medkits actually are full * why did this have so many issues
Iajret
pushed a commit
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#3440
Original PR: tgstation/tgstation#84479
About The Pull Request
Partial port of DaedalusDock/daedalusdock#996
update_ambience_area()andrefresh_looping_ambience()intocode\controllers\subsystem\ambience.dmfor better organization.Why It's Good For The Game
Mostly to tackle a prefrence bug where ghosts are unable to turn off ambience buzz. But this also includes ambience buzz requiring a powered area. Makes the station feel more dead when there's no enviorment power. There should also be no buzzing inside space.
Changelog
🆑 Kapu (ported by StrangeWeirdKitten)
fix: Ambience buzz will now respect ship ambience prefrences for observers.
sound: Ambience buzz requires APC enviorment power to function
/:cl: