Skip to content

#5864 Use built in linkify html type #5876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 5, 2024
Merged

#5864 Use built in linkify html type #5876

merged 6 commits into from
Dec 5, 2024

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Dec 2, 2024 •
edited by sosnovsky
Loading

This PR uses built in linkify html type

close #5864 // if this PR closes an issue

Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is documented clearly and usefully, or doesn't need documentation
  • is free of vulnerabilities

@ioanmo226 ioanmo226 marked this pull request as ready for review December 3, 2024 01:52
@ioanmo226 ioanmo226 requested a review from sosnovsky as a code owner December 3, 2024 01:52
sosnovsky
sosnovsky reviewed Dec 3, 2024
View reviewed changes
sosnovsky
sosnovsky previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

@sosnovsky sosnovsky enabled auto-merge (squash) December 3, 2024 09:40
@ioanmo226 ioanmo226 requested a review from sosnovsky December 5, 2024 09:47
sosnovsky
sosnovsky approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sosnovsky sosnovsky merged commit 08ca0f0 into master Dec 5, 2024
13 checks passed
@sosnovsky sosnovsky deleted the 5864-use-built-in-linkify-html-types branch December 5, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use built-in linkify-html types
2 participants
@ioanmo226 @sosnovsky