feat: partial separation of dynamiclink into `wasmplus` #22

da1suk8 · 2023-04-06T03:07:26Z

Description

The dynamiclink branch was partially separated into wasmplus.

Separation Process

Merge to 60fec8a where the separation was made. Check the difference.
Merge to 514953c
Check the difference, and partially separated

Because the cosmwasmAPI is not exposed to the outside world, it could not be separated.
It is necessary to use a different method for separation.

When Finschia/wasmvm#94 is merged, update commit-hash and add CHANGELOG.

commit-hash
CHANGELOG

How has this been tested?

make build
make test

Checklist:

I followed the contributing guidelines and code of conduct.
I have added a relevant changelog to CHANGELOG.md
I have added tests to cover my changes.
I have updated the documentation accordingly.
I have updated API documentation client/docs/swagger-ui/swagger.yaml

Bumps [github.com/spf13/cast](https://github.com/spf13/cast) from 1.4.1 to 1.5.0. - [Release notes](https://github.com/spf13/cast/releases) - [Commits](spf13/cast@v1.4.1...v1.5.0) --- updated-dependencies: - dependency-name: github.com/spf13/cast dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.12.1 to 1.12.2. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.12.1...v1.12.2) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

* Publish protobufs on release tags * Fix regex to match also rc versions

…ithub.com/prometheus/client_golang-1.12.2 Bump github.com/prometheus/client_golang from 1.12.1 to 1.12.2

* Fix wasm simulations + make functions compatible with tgrade * Fix lint issues * Fix simulation setup * Make simulations store msg pass * Use default values params to make operations succeed * Normalize wasm store * Add simulations to circleci config * Run simulation in temp dir * Store sim logs * Increase circleci machine type * Extract reflect contract api into helper * Add execute msg to simulations * Embed refect wasm contract Co-authored-by: Pino' Surace <[email protected]>

feat: setup and run script in dockerfile

…ithub.com/spf13/cast-1.5.0 Bump github.com/spf13/cast from 1.4.1 to 1.5.0

Remove unused NegotiateAppVersion ibc callback

Update config.yml

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.1 to 1.7.2. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.7.1...v1.7.2) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

…ithub.com/stretchr/testify-1.7.2 Bump github.com/stretchr/testify from 1.7.1 to 1.7.2

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.2 to 1.8.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.7.2...v1.8.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

…ithub.com/stretchr/testify-1.8.0 Bump github.com/stretchr/testify from 1.7.2 to 1.8.0

Bump sdk version to v0.45.5

…lusion Remove unnecessary string

Remove outdated proto.md

Output events are not part of consensus and can be non-deterministic

This is because it references cosmwasmAPI, which is not exposed to the outside world

github-advanced-security · 2023-04-06T03:22:09Z

You have successfully added a new CodeQL configuration .github/workflows/codeql-analizer.yml:CodeQL-Build. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

da1suk8 · 2023-04-07T07:58:48Z

As for the TestCheckLibwasmVersion that fails in ci, it succeed if the commit of wasmvm is set appropriately instead of replace in go.mod.

loloicci · 2023-04-10T08:23:22Z

commit titles of fcc1b46 and ce22554 do not start with the kind of the commit. (for example fix, feat, ci, ...)

that cannot be separated

…smplus_dynamic

loloicci · 2023-04-06T15:15:44Z

appplus/params/params.go

@@ -0,0 +1,8 @@
+package params


Is this file needed?

The following is added according to main branch.

loloicci · 2023-04-12T11:53:29Z

Can fcc1b46 's api access the wasmplus's keeper?
It needs to get "is inactive contract" in "call callable point" which will be added in Finschia/wasmvm#102.

da1suk8 · 2023-04-13T08:04:05Z

@loloicci

Can fcc1b46 's api access the wasmplus's keeper?
It needs to get "is inactive contract" in "call callable point" which will be added in Finschia/wasmvm#102.

Access is not possible.
Since it is a circular reference, it may need to be separated in a different way.

I created #25
I will deal with this in a separate issue.

da1suk8 · 2023-04-14T10:00:16Z

I will consider using a different method to partial separate dynamiclink into wasmplus since they are incompatible with #26.
From now on, this issue will be handled #25, and the PR here will be closed.

dependabot bot and others added 30 commits May 12, 2022 08:12

Publish protobufs on release tags (CosmWasm#869)

aadc8bf

* Publish protobufs on release tags * Fix regex to match also rc versions

Merge pull request CosmWasm#857 from CosmWasm/dependabot/go_modules/g…

34e0783

…ithub.com/prometheus/client_golang-1.12.2 Bump github.com/prometheus/client_golang from 1.12.1 to 1.12.2

feat: setup and run script in dockerfile

1da0a6f

Merge pull request CosmWasm#875 from j0nl1/feat/setup_and_run

490d31e

feat: setup and run script in dockerfile

Merge pull request CosmWasm#855 from CosmWasm/dependabot/go_modules/g…

4525d51

…ithub.com/spf13/cast-1.5.0 Bump github.com/spf13/cast from 1.4.1 to 1.5.0

Remove obsolete ibc callback

f6ca36f

Update config.yml

3997ab1

Merge pull request CosmWasm#879 from CosmWasm/ibc_cleanup

775f1cc

Remove unused NegotiateAppVersion ibc callback

Merge pull request CosmWasm#883 from faddat/patch-4

9bd57b0

Update config.yml

Merge pull request CosmWasm#886 from CosmWasm/dependabot/go_modules/g…

14688c0

…ithub.com/stretchr/testify-1.7.2 Bump github.com/stretchr/testify from 1.7.1 to 1.7.2

Bump sdk version to v0.45.5

59e0710

Merge pull request CosmWasm#895 from CosmWasm/dependabot/go_modules/g…

1ab9f73

…ithub.com/stretchr/testify-1.8.0 Bump github.com/stretchr/testify from 1.7.2 to 1.8.0

Merge pull request CosmWasm#888 from CosmWasm/sdk-upgrade0455

3787f3d

Bump sdk version to v0.45.5

Remove unnecessary string

72e8b7d

Merge pull request CosmWasm#899 from shiki-tak/unnecessary-string-inc…

39be44b

…lusion Remove unnecessary string

Prevent migration to a restricted code

ffd8a3c

Restrict code access config modifications

e5ff7c1

Remove outdated proto.md

b570f49

Merge pull request CosmWasm#902 from CosmWasm/remove-outdated-proto-docs

8213046

Remove outdated proto.md

Remove unnecessary error check

29340b6

Create .gitpod.yml

3864815

Don't pass non-wasm events to reply()

ee44cc0

Output events are not part of consensus and can be non-deterministic

Oops

9671a21

Add changelog for fix

f7211b8

Fix tests in keeper

ce1cf74

da1suk8 added 3 commits April 5, 2023 17:48

test: set testdata

d666763

The part that cannot be separated into wasmplus

fcc1b46

This is because it references cosmwasmAPI, which is not exposed to the outside world

dynamic link test separated into wasmplus

ce22554

da1suk8 self-assigned this Apr 6, 2023

da1suk8 mentioned this pull request Apr 6, 2023

Propose methods to completely separate the functions of dynamic_link into wasmplus #23

Closed

da1suk8 added 2 commits April 7, 2023 16:24

ci test

3f24dba

fix: gofmt

dee16ff

da1suk8 marked this pull request as ready for review April 7, 2023 07:56

da1suk8 requested review from loloicci, dudong2, Kynea0b and zemyblue April 7, 2023 07:59

Kynea0b previously approved these changes Apr 12, 2023

View reviewed changes

da1suk8 added 3 commits April 12, 2023 12:16

chore: add description of the parts of wasmplus

cadf716

that cannot be separated

build: update commit-hash of wasmvm

3939160

test: update on expected gas

3bd8e61

da1suk8 dismissed Kynea0b’s stale review via 3bd8e61 April 12, 2023 03:17

fix: go format

bc1c630

da1suk8 changed the title ~~feat: partial separation of dynamiclink into wasmplus~~ feat: partial separation of dynamiclink into wasmplus Apr 12, 2023

Merge remote-tracking branch 'upstream/dynamic_link' into separate_wa…

6cc8cb1

…smplus_dynamic

da1suk8 requested a review from Kynea0b April 12, 2023 09:20

loloicci reviewed Apr 12, 2023

View reviewed changes

da1suk8 mentioned this pull request Apr 14, 2023

Enable the use of wasmplus's IsInactiveContract() in cosmwasmAPI #25

Closed

da1suk8 closed this Apr 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: partial separation of dynamiclink into `wasmplus` #22

feat: partial separation of dynamiclink into `wasmplus` #22

da1suk8 commented Apr 6, 2023 •

edited

Loading

github-advanced-security bot commented Apr 6, 2023

da1suk8 commented Apr 7, 2023

loloicci commented Apr 10, 2023

loloicci Apr 6, 2023

da1suk8 Apr 13, 2023

loloicci commented Apr 12, 2023

da1suk8 commented Apr 13, 2023 •

edited

Loading

da1suk8 commented Apr 14, 2023 •

edited

Loading

feat: partial separation of dynamiclink into wasmplus #22

feat: partial separation of dynamiclink into wasmplus #22

Conversation

da1suk8 commented Apr 6, 2023 • edited Loading

Description

How has this been tested?

Checklist:

github-advanced-security bot commented Apr 6, 2023

da1suk8 commented Apr 7, 2023

loloicci commented Apr 10, 2023

loloicci Apr 6, 2023

Choose a reason for hiding this comment

da1suk8 Apr 13, 2023

Choose a reason for hiding this comment

loloicci commented Apr 12, 2023

da1suk8 commented Apr 13, 2023 • edited Loading

da1suk8 commented Apr 14, 2023 • edited Loading

feat: partial separation of dynamiclink into `wasmplus` #22

feat: partial separation of dynamiclink into `wasmplus` #22

da1suk8 commented Apr 6, 2023 •

edited

Loading

da1suk8 commented Apr 13, 2023 •

edited

Loading

da1suk8 commented Apr 14, 2023 •

edited

Loading