Fail validation when app context receives an unknown property #782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magsallen
reviewed
Mar 19, 2020
|
Nothing that I'm aware of! 🤞 |
|
I had to add the I also noticed some things that could be deleted from the kitchen sink example 😶 |
magsallen
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All app context properties are appended to tracking events. The schema currently allows unknown properties to added for convenience, however this is causing the analytics team problems as they are receiving unexpected data.
This updates the app context schema to disallow unknown properties and reiterates how app context is used in the readme.
We will provide another appropriate mechanism for passing data between the server and client (cc #761).