Skip to content

Fix jenv crashing silently #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2022
Merged

Fix jenv crashing silently #23

merged 1 commit into from
Mar 16, 2022
+4 −4

Conversation

serg06
Copy link
Contributor

@serg06 serg06 commented Mar 16, 2022 •
edited
Loading

This fixes two issues:

  1. On error, the script was closing the entire terminal so we couldn't even see the error output.
  2. The logic was incorrect, causing the script to close if pwsh.exe didn't exist but powershell.exe did.

@serg06
Fix jenv crashing silently
6816230 
This fixes two issues:
1. On error, the script was closing the command prompt so we couldn't even see the error output.
2. The logic was incorrect, causing the script to close if `pwsh.exe` didn't exist but `powershell.exe` did.
@FelixSelter
Copy link
Owner

Thanks this looks great

@FelixSelter FelixSelter merged commit 63b3d81 into FelixSelter:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serg06 @FelixSelter