-
Notifications
You must be signed in to change notification settings - Fork 444
Multiplayer ALE #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Multiplayer ALE #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces: 1) root CMakeLists.txt for the project. 2) src CMakeLists.txt which builds the C++ library. 3) CMakeLists.txt for each module in src which adds the proper source files to the ale target in src/CMakeLists.txt 4) Centralized version control is now done through a cmake substitution: 'version.hpp.in' -> 'version.hpp' with the current project version and the current git sha if possible. 5) cmake module directory containing some template files for the library installation.
This reverts commit 7b49739.
This reverts commit f6486b9.
This reverts commit 77d69fd.
Could you maintain a separate branch apart from your main project that's rebased on the current head? This is a little too much to take a look at in its current state. |
@JesseFarebro We'll do this, but it's going to take a little while, and we need to fix something in entombed cooperative first. |
fixed entombed cooperative rewards
Add ability to set RAM
fixed checkers rewards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atari has some great multiplayer games. This PR starts the process of supporting these games with:
New API
The new api has the following methods in addition to all the old ones (in both the python and c++ interfaces):
In addition, there are a couple of other changes to ALE functionality
Merge process
This merge process will likely be lengthy, so we expect to host a fork of ALE ourselves in the medium term, but we hope we can get various stakeholders excited about the potential of multiplayer ALE.