Fix of tmp db size metric #465
Conversation
integration/metric.go
Outdated
| func genericNameOfTmpDB(name string) string { | ||
| match := tmpDbNameMask.FindStringSubmatch(name) | ||
| if len(match) == 3 { | ||
| return match[1] + "es" |
There was a problem hiding this comment.
Ending with "es" looks a bit strange for gossipes and epoches.
We might include all (gossip-, lachesis- and epoch-) into epochs like before?
There was a problem hiding this comment.
How about gossip-tmp, lachesis-tmp and epoch-tmp ?
There was a problem hiding this comment.
@rus-alex I would say it is more like "gossip-epoch", "lachesis-epoch" and "epoch".
But I like the idea of one "epochs" generic name more.
There was a problem hiding this comment.
@hkalina , but gossip-%d and lachesis-%d are not the same DB for "legacy-ldb" and "legacy-pbl" layouts. So we should have different metrics for each, not a common "epochs".
I agree that we mostly use "ldb-1" and "pbl-1" now. But it may be changed later.
There was a problem hiding this comment.
Or, we may add a new kind of temporary db.
Replaces infinite number of metrics for each tmp DB with single generic metric for each kind of tmp DB.
Makes it easier to build a dashboard, prevents the leaks like #461