Cache NetworkVersion in VerWarcher #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaarok
force-pushed
the
cache-network-version
branch
from
2596cd1 to
a21382b
Compare
thaarok
force-pushed
the
cache-network-version
branch
from
a21382b to
56c5fa4
Compare
uprendis
approved these changes
Jun 9, 2022
hadv
approved these changes
Jun 9, 2022
|
@uprendis Hi, as this PR has two reviews as required, can you merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go-Opera currently consume 5% of all database reading time in repeated reading of NetVersion:
This pull requests adds cache into the VerWatcher Store, which reduce this to almost zero - the value is loaded from the database only once and keep up-to-date in the cache on updates.