Skip to content

GraphQL #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 60 commits into from
Jan 1, 2024
Merged

GraphQL #44

merged 60 commits into from
Jan 1, 2024

Conversation

martindale
Copy link
Member

@martindale martindale commented Apr 2, 2023

GraphQL support at /services/graphql and some general cleanup

Notable Changes

  • Migrates compiled applications to production mode — much smaller output!

TODO

Ready for Review (RFR)

  • restore INVENTORY_REQUEST message in Remote

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Attention: 141 lines in your changes are missing coverage. Please review.

Comparison is base (01826db) 55.35% compared to head (fd0ff76) 55.45%.

Files Patch % Lines
types/server.js 70.28% 63 Missing ⚠️
types/remote.js 68.61% 43 Missing ⚠️
types/spa.js 50.00% 18 Missing ⚠️
types/sandbox.js 71.42% 8 Missing ⚠️
types/client.js 37.50% 5 Missing ⚠️
types/app.js 0.00% 2 Missing ⚠️
types/component.js 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   55.35%   55.45%   +0.09%     
==========================================
  Files          24       24              
  Lines        3405     3709     +304     
==========================================
+ Hits         1885     2057     +172     
- Misses       1520     1652     +132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martindale martindale requested a review from chrisinajar April 9, 2023 08:48
@martindale martindale added the enhancement New feature or request label Apr 9, 2023
@martindale martindale self-assigned this Apr 9, 2023
@martindale martindale added this to the 0.2.0 milestone Apr 9, 2023
Comment on lines 3 to 7
alias: String
host: String
port: Int
pubkey: String
services: [Service]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these all really optional?

types/server.js Outdated
Comment on lines 763 to 774
this.graphQLSchema = new GraphQLSchema({
query: new GraphQLObjectType({
name: 'Query',
fields: {
hello: {
type: GraphQLString,
resolve: () => 'world',
}
}
})
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm....

@martindale martindale merged commit 9f42472 into master Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

3 participants