Fix bestpath reason being incorrectly set in some cases #18819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configuration:
|---------------------- R3 -------- 192.168.199.0/24
| 192.16.3.0/24 RID 1.1.1.3
| AS 65003
| MED 150
|
|
| 192.16.2.0/24
R1 -------------------- R2 -------- 192.168.199.0/24
AS 65001 RID 1.1.1.2
| AS 65024
| MED 200
|
|
|---------------------- R4 -------- 192.168.199.0/24
192.16.4.0/24 RID 1.1.1.4
AS 65024
MED 100
Where you bring up r2, then r3 and the r4 the bestpath reason
selected would be Router-id and instead it should be MED.
Fix the bgp_route code to correctly have the correct bestpath
reason.
Fixes: FRRouting#16914
Signed-off-by: Donald Sharp <[email protected]>
Implement a topotest that shows a situation where the bestpath was being incorrectly applied. This test will be used to help show that bestpath is correct. Signed-off-by: Donald Sharp <[email protected]>
|
@Mergifyio backport stable/10.3 stable/10.2 stable/10.1 stable/10.0 |
✅ Backports have been created
|
This was referenced May 16, 2025
donaldsharp
added a commit
that referenced
this pull request
May 16, 2025
Fix bestpath reason being incorrectly set in some cases (backport #18819)
donaldsharp
added a commit
that referenced
this pull request
May 16, 2025
Fix bestpath reason being incorrectly set in some cases (backport #18819)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The best path reason was being incorrectly set in some cases. Let's fix that. Also write a test to show that it is fixed.