ripd, ripngd: Timer values #18805
Merged
ripd, ripngd: Timer values #18805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
force-pushed
the
fix/rip_passive_interface_failures_random
branch
2 times, most recently
from
c0535e5 to
019144a
Compare
ripng is able to set as low as 1 for every, why should we limit for RIP. Even more, YANG model for RIP specifies a range starting from 1. https://datatracker.ietf.org/doc/html/rfc8695 Signed-off-by: Donatas Abraitis <[email protected]>
This is not YANG model defines it and it says that it MUST be higher than hold interval. Interval before a route is flushed from the routing table. This value must be larger than the value for the invalid-interval argument. https://datatracker.ietf.org/doc/html/rfc8695 Signed-off-by: Donatas Abraitis <[email protected]>
ton31337
force-pushed
the
fix/rip_passive_interface_failures_random
branch
from
019144a to
6563c01
Compare
They are uint16, not uint32. Signed-off-by: Donatas Abraitis <[email protected]>
Signed-off-by: Donatas Abraitis <[email protected]>
https://datatracker.ietf.org/doc/html/rfc8695 This is not YANG model defines it and it says that it MUST be higher than hold interval. Interval before a route is flushed from the routing table. This value must be larger than the value for the invalid-interval argument. leaf flush-interval { type uint16 { range "1..32767"; } units "seconds"; default "240"; description "Interval before a route is flushed from the routing table. This value must be larger than the value for the invalid-interval argument."; } Signed-off-by: Donatas Abraitis <[email protected]>
ton31337
force-pushed
the
fix/rip_passive_interface_failures_random
branch
from
6563c01 to
585a8c4
Compare
We shouldn't care about trailing whitespaces. Signed-off-by: Donatas Abraitis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.