SRv6: Allow configuring node-len 0 #18774
Conversation
raja-rajasekar
force-pushed
the
rajasekarr/nfl_len_node_len_0
branch
2 times, most recently
from
8844a9f to
a9beda5
Compare
raja-rajasekar
changed the title
|
The current change is a needed/basic one and can go in irrespective of the below query. But the next set of changes to be built on top of it is tricky, and I need your help. Ideally speaking, for a F1616(for example), we should be able to configure
However in today's code, we have ctx.flv.lcnode_func_len = node-len , while rather it should have been ctx.flv.lcnode_func_len =node-len + func-len I tried to fix this, but it breaks existing testcases (isis-ping and srv6 ping) because formats/e-wlibs have a default func-len as 16, and this is also being used for other purposes. How do we proceed with the next set of changes to make ctx.flv.lcnode_func_len =node-len + func-len? Would it be considered a @cscarpitta @pguibert6WIND @ton31337 @donaldsharp can you please comment on this and let me know the way to go |
tests/topotests/srv6_locator_custom_bits_length/test_srv6_locator_custom_bits_length.py
Outdated
Show resolved
Hide resolved
|
Carmine - please review ASAP. |
Currently the node-len for a locator can only be configured between the range 16-64. However, as per the RFC draft https://datatracker.ietf.org/doc/html/draft-ietf-spring-srv6-srh-compression-23#name-recommended-installation-of `` The SID 2001:db8:b1:f123:: bound to the End.X behavior for its local IGP adjacency 123 with the NEXT-CSID flavor is instantiated from LIB with Locator-Block length (LBL) = 48 (Locator-Block value 0x20010db800b1), Locator-Node length (LNL) = 0, Function length (FL) = 16 (Function value 0xf123), and Argument length (AL) = 64. `` End.X should be able to handle 0 node length. Fixing this by allowing the user to configure the node-len 0-64. Also distinguishing the not configured node-len and node-len 0 configuration. Signed-off-by: Rajasekar Raja <[email protected]>
raja-rajasekar
force-pushed
the
rajasekarr/nfl_len_node_len_0
branch
from
a9beda5 to
5f00926
Compare
|
Thanks Donatas and Russ! |
Zebra: Allow configuring node-len 0
Currently the node-len for a locator can only be configured between the range 16-64. However, as per the RFC draft
https://datatracker.ietf.org/doc/html/draft-ietf-spring-srv6-srh-compression-23#name-recommended-installation-of
End.X should be able to handle 0 node length.
Fixing this by allowing the user to configure the node-len 0-64. Also distinguishing the not configured node-len and node-len 0 configuration.