Skip to content

doc: state correct default behaviour of VTYSH_PAGER env if unset (vtysh manpage) #18691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

valentinbinotto
Copy link
Contributor

Modified section about environment variable VTYSH_PAGER in manpage about vtysh to reflect the default configuration for this env as described inside the FRR User Docs (https://docs.frrouting.org/en/latest/vtysh.html#envvar-VTYSH_PAGER)

Copy link
Member

@donaldsharp donaldsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect, if you run configure without --with-vtysh_pager the code defaults to more. See vtysh.c and config.h output

@valentinbinotto
Copy link
Contributor Author

valentinbinotto commented Apr 21, 2025

But in that case I suppose we should update the User docs accordingly as it currently (latest) states something different about the VTYSH_PAGER env (doc/user/vtysh.rst)?

VTYSH_PAGER
[..]
If this environment variable is unset, vtysh defaults to not using any pager.
[..]

@donaldsharp
Copy link
Member

LGTM now. Once CI finishes I'll get this in

@donaldsharp donaldsharp merged commit 827e1d6 into FRRouting:master Apr 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants