Memory leaks all over #18544
Merged
Memory leaks all over #18544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit: e0ae285 Modified the fsm state machine to attempt to not clear routes on a peer that was not established. The peer should be not a peer self. We do not want to ever clear the peer self. Signed-off-by: Donald Sharp <[email protected]>
There are some tables not being freed upon shutdown. This is happening because the table is being locked as dests are being put on the metaQ. When in shutdown it was clearing the MetaQ it was not unlocking the table Signed-off-by: Donald Sharp <[email protected]>
Several daemons were not calling prefix_list_reset to clean up memory on shutdown. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
memory_leaks_all_over
branch
from
4d6861f to
ecdfdec
Compare
This function will clean up memory associated with affinity maps on shutdown Signed-off-by: Donald Sharp <[email protected]>
Affinity maps are abeing leaked. STOP Signed-off-by: Donald Sharp <[email protected]>
Zebra is using affinity maps but not cleaning up memory on shutdown. BAD! Signed-off-by: Donald Sharp <[email protected]>
Fix this: ==3890443== 92 (48 direct, 44 indirect) bytes in 1 blocks are definitely lost in loss record 68 of 98 ==3890443== at 0x484DA83: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==3890443== by 0x49737B3: qcalloc (memory.c:106) ==3890443== by 0x3EA63B: aspath_dup (bgp_aspath.c:703) ==3890443== by 0x2F5438: route_set_aspath_exclude (bgp_routemap.c:2604) ==3890443== by 0x49BC52A: route_map_apply_ext (routemap.c:2708) ==3890443== by 0x2C1069: bgp_input_modifier (bgp_route.c:1925) ==3890443== by 0x2C9F12: bgp_update (bgp_route.c:5205) ==3890443== by 0x2CF281: bgp_nlri_parse_ip (bgp_route.c:7271) ==3890443== by 0x2A28C7: bgp_nlri_parse (bgp_packet.c:338) ==3890443== by 0x2A7F5C: bgp_update_receive (bgp_packet.c:2448) ==3890443== by 0x2ACCA6: bgp_process_packet (bgp_packet.c:4046) ==3890443== by 0x49EB77C: event_call (event.c:2019) ==3890443== by 0x495FAD1: frr_run (libfrr.c:1247) ==3890443== by 0x208D6D: main (bgp_main.c:557) Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
memory_leaks_all_over
branch
from
ecdfdec to
354aee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits